Bug 85478 – [Qt] Buildfix for newer Qt5

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

Trunk WebKit doesn't build with the latest Qt5 hash: 1968c54d4f7c96d2df40c0e2b416125adf217634

/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h:163: error: 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' is private
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_class.cpp:103: error: within this context
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_class.cpp:103: error: passing 'const QMetaMethod' as 'this' argument of 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' discards qualifiers
ICECC[10908] 05:16:54: Compiled on 10.6.1.14
make[3]: *** [obj/release/bridge/qt/qt_class.o] Error 1
make[3]: *** Waiting for unfinished jobs....
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h: In member function 'virtual void JSC::Bindings::QtInstance::getPropertyNames(JSC::ExecState*, JSC::PropertyNameArray&)':
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h:163: error: 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' is private
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_instance.cpp:240: error: within this context
ICECC[10910] 05:16:54: Compiled on 10.6.1.14
make[3]: *** [obj/release/bridge/qt/qt_instance.o] Error 1
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h: In function 'int JSC::Bindings::findMethodIndex(JSC::ExecState*, const QMetaObject*, const QByteArray&, bool, QVarLengthArray<QVariant, 10>&, void**, JSC::JSObject**)':
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h:163: error: 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' is private
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1164: error: within this context
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1164: error: passing 'const QMetaMethod' as 'this' argument of 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' discards qualifiers
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h:163: error: 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' is private
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1167: error: within this context
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1167: error: passing 'const QMetaMethod' as 'this' argument of 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' discards qualifiers
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h:163: error: 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' is private
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1241: error: within this context
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h:163: error: 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' is private
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1247: error: within this context
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h:163: error: 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' is private
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1277: error: within this context
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h:163: error: 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' is private
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1317: error: within this context
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h:163: error: 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' is private
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1336: error: within this context
/usr/local/Trolltech/Qt5/Qt-5.0.0-r29/include/QtCore/qmetaobject.h:163: error: 'char* QMetaMethod::signature(renamedInQt5_warning_checkTheLifeTime*)' is private
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1357: error: within this context
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp: At global scope:
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1793: error: cannot convert 'const char*' to 'const QByteArrayData*' in initialization
cc1plus: warnings being treated as errors
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1793: error: missing initializer for member 'QMetaObject::<anonymous struct>::relatedMetaObjects'
/home/oszi/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1793: error: missing initializer for member 'QMetaObject::<anonymous struct>::extradata'

[Csaba Osztrogonác]

Created attachment 140012 [details]
WIP buildfix patch

Most of the build fail were caused by renaming QMetaMethod::signature() to methodSignature()
by qtbase - 96f2365cf4cebc074c3171878dcd25ce19ee7486 - QTBUG-24154

The attached patch fixed it, but I'm not sure if it is the proper fix.

After it I got one more problem:
/mnt/raptor1/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1793: error: cannot convert 'const char*' to 'const QByteArrayData*' in initialization
/mnt/raptor1/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1793: error: missing initializer for member 'QMetaObject::<anonymous struct>::relatedMetaObjects'
/mnt/raptor1/WebKit/Source/WebCore/bridge/qt/qt_runtime.cpp:1793: error: missing initializer for member 'QMetaObject::<anonymous struct>::extradata'

I don't know what is it and how can be fixed. Feel free to pick this bug up and fix it.

(Qt5 hash: 1968c54d4f7c96d2df40c0e2b416125adf217634, the previous 6d70a4f5cb1a17d8973fd58f976e68f768d25d09 works without any buildfix.)

[Tor Arne Vestbø]

Created attachment 140015 [details]
0001-Qt-Don-t-pass-viewport-create-function-to-quick_test.patch

Built against Qt5 1968c54d4f7c96d2df40c0e2b416125adf217634

[Tor Arne Vestbø]

Created attachment 140016 [details]
0002-Qt-Update-Qt-bridge-after-changes-to-QMetaMethod.patch

Sans changelog

[Csaba Osztrogonác]

Created attachment 140020 [details]
one more renaming thing

[Csaba Osztrogonác]

Created attachment 140221 [details]
buildfix 3/1

[Csaba Osztrogonác]

Created attachment 140222 [details]
buildfix 3/2

[Csaba Osztrogonác]

Created attachment 140223 [details]
buildfix 3/3

[WebKit Review Bot]

Attachment 140223 [details] did not pass style-queue:

Source/WebCore/bridge/qt/qt_runtime.cpp:1785:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime.cpp:1792:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime.cpp:1793:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime.cpp:1795:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/bridge/qt/qt_runtime.cpp:1798:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/bridge/qt/qt_runtime.cpp:1808:  Declaration has space between type name and * in QtConnectionObject *_t  [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime.cpp:1811:  Semicolon defining empty statement. Use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:55:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:72:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:73:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:76:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:78:  Missing space before {  [whitespace/braces] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:78:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:79:  Missing space before {  [whitespace/braces] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:79:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:147:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:158:  Declaration has space between type name and * in JSObject *object  [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:159:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:159:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:236:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:235:  Missing space before ( in switch(  [whitespace/parens] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:288:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:342:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:363:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:437:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:599:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:623:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:626:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:633:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:647:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:650:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:656:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:660:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:666:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:665:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:772:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:775:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:818:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:819:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:820:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:821:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:831:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:832:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:833:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:834:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:835:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:836:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:837:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:838:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:839:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:857:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:858:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:862:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:935:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:967:  Missing space after ,  [whitespace/comma] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1020:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1057:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1089:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1097:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1114:  Missing spaces around =  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1132:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1184:  Missing space before ( in foreach(  [whitespace/parens] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1193:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1198:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1219:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1222:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1281:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1280:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1289:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1297:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1302:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1308:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1371:  Missing spaces around =  [whitespace/operators] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1433:  Declaration has space between type name and * in QObject *obj  [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1436:  Declaration has space between type name and * in void *qargs  [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1452:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1467:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1592:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1602:  Declaration has spFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
ace between type name and * in JSObject *asObj  [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1619:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1620:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1627:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1633:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1656:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1649:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1669:  Missing space before ( in foreach(  [whitespace/parens] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1696:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1772:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1773:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1774:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1780:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1783:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1800:  Declaration has space between type name and * in void *QtConnectionObject  [whitespace/declaration] [3]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1802:  More than one command on the same line in if  [whitespace/parens] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1809:  _c is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1809:  _id is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1894:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebCore/bridge/qt/qt_runtime_qt4.cpp:1913:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 100 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 140221 [details]
buildfix 3/1

Attachment 140221 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12543316

[Early Warning System Bot]

Comment on attachment 140222 [details]
buildfix 3/2

Attachment 140222 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12531170

[Early Warning System Bot]

Comment on attachment 140223 [details]
buildfix 3/3

Attachment 140223 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12630146

[Csaba Osztrogonác]

Comment on attachment 140221 [details]
buildfix 3/1

Clearing flags on attachment: 140221

Committed r116100: <http://trac.webkit.org/changeset/116100>

[Csaba Osztrogonác]

Comment on attachment 140222 [details]
buildfix 3/2

Clearing flags on attachment: 140222

Committed r116101: <http://trac.webkit.org/changeset/116101>

[Csaba Osztrogonác]

Comment on attachment 140223 [details]
buildfix 3/3

Clearing flags on attachment: 140223

Committed r116102: <http://trac.webkit.org/changeset/116102>