Bug 85476 - [Gtk] ImageDiff crashes when it can't open a display
Summary: [Gtk] ImageDiff crashes when it can't open a display
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-03 05:00 PDT by Zan Dobersek
Modified: 2012-05-03 06:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2012-05-03 05:22 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-05-03 05:00:57 PDT 
This happens regularly on the GTK 64-bit Debug builder. Here's stderr output:

(ImageDiff:14017): Gdk-WARNING **: cannot open display
Comment 1 Zan Dobersek 2012-05-03 05:03:40 PDT 
The problem originates from the gdk_init function call[1]. It turns out GdkPixbufLoader doesn't actually require gdk_init() to be called, meaning this should be replaced by only calling g_type_init() and the crashes should go away.

[1] http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/gtk/ImageDiff.cpp#L181
Comment 2 Zan Dobersek 2012-05-03 05:22:51 PDT 
Created attachment 139986 [details]
Patch
Comment 3 Zan Dobersek 2012-05-03 06:15:09 PDT 
Comment on attachment 139986 [details]
Patch

Clearing flags on attachment: 139986

Committed r115967: <http://trac.webkit.org/changeset/115967>
Comment 4 Zan Dobersek 2012-05-03 06:15:24 PDT 
All reviewed patches have been landed.  Closing bug.