Tool/Scripts/run-qtwebkit-tests hangs after it ran all Qt API tests with -j1 (run only one job) It should be fixed.
I'm going to check what causes this problem.
Created attachment 145726 [details] Proposed patch It's likely that this could be solved by canceling the timer of process_killer when results of tests are returned.
View in context: https://bugs.webkit.org/attachment.cgi?id=145726&action=review > Tools/Scripts/run-qtwebkit-tests:158 > log.info("Finished %s", test_suite.test_file_name()) > + timer.cancel() > return test_suite This is not in the correct place. If timeout is not set the 'timer' will be a "None" value, calling cancel() on that will result an AttributeError. You should check if the timer is set to a valid object. So I would give an r- for now (sadly I can't set that flag).
Created attachment 145738 [details] proposed patch
View in context: https://bugs.webkit.org/attachment.cgi?id=145738&action=review > Tools/Scripts/run-qtwebkit-tests:158 > + if timeout: > + timer.cancel() Now it looks a lot better. I'll give it a non-reviewer r+ :)
(In reply to comment #5) > View in context: https://bugs.webkit.org/attachment.cgi?id=145738&action=review > Now it looks a lot better. I'll give it a non-reviewer r+ :) Thank you. : )
Comment on attachment 145738 [details] proposed patch r=me. Thanks for the fix.
Comment on attachment 145738 [details] proposed patch Clearing flags on attachment: 145738 Committed r119588: <http://trac.webkit.org/changeset/119588>
All reviewed patches have been landed. Closing bug.