Bug 85439 – Add dpi to css3-images image-resolution

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[David Barr]

The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#image-resolution

I propose to introduce image-resolution, initially behind a runtime feature flag.

Advertised on webkit-dev:
http://thread.gmane.org/gmane.os.opendarwin.webkit.devel/20505

As a second step, add support for dpi values.

[David Barr]

Created attachment 139928 [details]
Patch

[David Barr]

Created attachment 143741 [details]
Patch

Updated ref-test.

[David Barr]

Created attachment 144955 [details]
Patch

Updated patch to use compile time flag.

[David Barr]

Created attachment 147047 [details]
Patch

Rebased against r119984: <http://trac.webkit.org/changeset/119984>

[David Barr]

Ojan, Tony: I've updated this patch to reflect how the DPPX patch was adapted for landing.

[Tony Chang]

Comment on attachment 147047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147047&action=review

> LayoutTests/fast/css/image-resolution/image-resolution.html:64
> +var resolutions = ['0dppx', '1dppx', '2dppx', '3dppx', '4dppx',
> +                   '0dpi', '96dpi', '192dpi', '288dpi', '384dpi',
> +                   '150dpi', '300dpi', '450dpi', '600dpi', ''];

Should we test some fractional values?  What about negative numbers?

[David Barr]

I'll include tests for fractional values when I add dpcm support.
I'm thinking of adding a test just for invalid values once the units have landed.

[David Barr]

Comment on attachment 147047 [details]
Patch

Clearing cq, as there is a conflicting patch in the queue. Will rebase when it lands.

[David Barr]

Created attachment 147213 [details]
Patch for landing

Rebased against the pending patch for CSS variables: https://bugs.webkit.org/show_bug.cgi?id=85580

[David Barr]

Comment on attachment 147213 [details]
Patch for landing

CSS variables has landed, so we are good to go! r120154: <http://trac.webkit.org/changeset/120154>

[WebKit Review Bot]

Comment on attachment 147213 [details]
Patch for landing

Clearing flags on attachment: 147213

Committed r120194: <http://trac.webkit.org/changeset/120194>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.