Bug 85436 - webkitpy: Remove sys.platform accesses in CrashLogs.
Summary: webkitpy: Remove sys.platform accesses in CrashLogs.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on: 85452
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-02 17:11 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-05-03 09:22 PDT (History)
7 users (show)

See Also:


Attachments
Patch (8.11 KB, patch)
2012-05-02 17:12 PDT, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Same patch with the missing import statement (8.10 KB, patch)
2012-05-03 08:06 PDT, Raphael Kubo da Costa (:rakuco)
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-05-02 17:11:27 PDT
webkitpy: Remove sys.platform accesses in CrashLogs.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-05-02 17:12:26 PDT
Created attachment 139920 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-02 17:30:29 PDT
Committed r115918: <http://trac.webkit.org/changeset/115918>
Comment 3 Andy Estes 2012-05-02 20:09:29 PDT
This is causing test-webkitpy to fail on Apple's Lion bot. See <http://build.webkit.org/builders/Lion%20Debug%20%28Tests%29/builds/6134/steps/webkitpy-test/logs/stdio>
Comment 4 Andy Estes 2012-05-02 21:08:52 PDT
Rolled out in <http://trac.webkit.org/changeset/115935>.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-05-03 08:06:39 PDT
Created attachment 140017 [details]
Same patch with the missing import statement
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-05-03 09:22:43 PDT
Committed r115977: <http://trac.webkit.org/changeset/115977>