Bug 85433 - Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare with one another (and easier to autogenerate)
Summary: Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 85456
  Show dependency treegraph
 
Reported: 2012-05-02 16:38 PDT by Eric Seidel (no email)
Modified: 2012-05-03 14:16 PDT (History)
5 users (show)

See Also:


Attachments
Patch (23.31 KB, patch)
2012-05-02 16:44 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-05-02 16:38:55 PDT
Sort ENABLE_ defines in FeatureDefines.xcconfig files to make them easier to compare with one another (and easier to autogenerate)
Comment 1 Eric Seidel (no email) 2012-05-02 16:44:01 PDT
Created attachment 139915 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-02 16:46:05 PDT
I sorted each file by itself, so as to be sure not to change their contents at all.  This patch very-intentionally should have no functional change.

I also removed the arbitrary spacing between various defines, as now that they have a well defined ordering, there isn't a lot of point.

Once I post my auto-gen script, it will be very easy to make these files look however we like, and change it as many times as we like, w/o worrying about whether they are kept perfectly in sync with one another.
Comment 3 Eric Seidel (no email) 2012-05-02 18:40:58 PDT
bug 85435 is the equivalent re-sort for the Win port.
Comment 4 Eric Seidel (no email) 2012-05-02 18:41:15 PDT
I meant bug 85445 of course. :)
Comment 5 WebKit Review Bot 2012-05-02 19:51:32 PDT
Comment on attachment 139915 [details]
Patch

Clearing flags on attachment: 139915

Committed r115931: <http://trac.webkit.org/changeset/115931>
Comment 6 WebKit Review Bot 2012-05-02 19:51:39 PDT
All reviewed patches have been landed.  Closing bug.