Bug 85426 - webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
Summary: webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-02 15:46 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2012-05-02 15:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.25 KB, patch)
2012-05-02 15:48 PDT, Raphael Kubo da Costa (:rakuco) 		dpranke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-05-02 15:46:04 PDT 
webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-05-02 15:48:51 PDT 
Created attachment 139896 [details]
Patch
Comment 2 Dirk Pranke 2012-05-02 15:51:21 PDT 
Comment on attachment 139896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139896&action=review

> Tools/Scripts/webkitpy/common/system/systemhost_mock.py:40
> +        self.filesystem = filesystem or MockFileSystem()

Since things like executive, filesystem are public properties, I sometimes will construct the object with the default values and then set the property, rather than passing it in (which is why filesystem wasn't previously a parameter). I don't know that my approach was better or worse than this, though.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-05-02 15:54:57 PDT 
Committed r115900: <http://trac.webkit.org/changeset/115900>