Bug 85405 - CSS 2.1 failure: table-height-algorithm-023 and -024 fail
Summary: CSS 2.1 failure: table-height-algorithm-023 and -024 fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL: http://test.csswg.org/suites/css2.1/2...
Keywords:
Depends on: 84167
Blocks: 47141 85652
  Show dependency tree / graph
 
Reported: 2012-05-02 12:43 PDT by Robert Hogan
Modified: 2012-05-17 12:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (114.80 KB, patch)
2012-05-09 12:53 PDT, Robert Hogan 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2012-05-02 12:43:42 PDT 
Treat vertical-align: [length] as baseline
Comment 1 Robert Hogan 2012-05-09 12:53:30 PDT 
Created attachment 141001 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-09 13:16:07 PDT 
Comment on attachment 141001 [details]
Patch

LGTM.
Comment 3 Eric Seidel (no email) 2012-05-09 13:16:50 PDT 
Comment on attachment 141001 [details]
Patch

I suspect you might make people happier if you landed the baselines next ot the tests (instead o in the platofrm/chromium directory) and then things like webkit-pach optimize-baselines will eventually move them to the right place as needed. :)
Comment 4 Robert Hogan 2012-05-09 13:24:17 PDT 
(In reply to comment #3)
> (From update of attachment 141001 [details])
> I suspect you might make people happier if you landed the baselines next ot the tests (instead o in the platofrm/chromium directory) and then things like webkit-pach optimize-baselines will eventually move them to the right place as needed. :)

OK, wow - another cool feature of webkit-patch I didn't know about.
Comment 5 Robert Hogan 2012-05-17 12:08:52 PDT 
Committed r117477: <http://trac.webkit.org/changeset/117477>