Bug 85390 - [chromium] Ensure synchronization in threaded unit tests by checking the sourceFrameNumber() to count commits
Summary: [chromium] Ensure synchronization in threaded unit tests by checking the sour...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-02 10:54 PDT by Dana Jansens
Modified: 2012-05-07 15:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.98 KB, patch)
2012-05-02 11:26 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch (6.19 KB, patch)
2012-05-02 12:03 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Patch for landing (5.82 KB, patch)
2012-05-07 15:24 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-05-02 10:54:43 PDT 
[chromium] Ensure synchronization in threaded unit tests by checking the sourceFrameNumber() to count commits
Comment 1 Dana Jansens 2012-05-02 11:26:37 PDT 
Created attachment 139844 [details]
Patch
Comment 2 Dana Jansens 2012-05-02 12:03:34 PDT 
Created attachment 139852 [details]
Patch

Use sourceFrameNumber everywhere in the atomic commit tests, and put back removed resetUsedTextures() calls
Comment 3 Adrienne Walker 2012-05-07 14:37:20 PDT 
Comment on attachment 139852 [details]
Patch

Ack, yes.  R=me.
Comment 4 WebKit Review Bot 2012-05-07 14:42:31 PDT 
Comment on attachment 139852 [details]
Patch

Rejecting attachment 139852 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
748 (offset -2 lines).
Hunk #5 succeeded at 1815 (offset -2 lines).
Hunk #6 succeeded at 1830 (offset -2 lines).
Hunk #7 succeeded at 1846 (offset -2 lines).
Hunk #8 succeeded at 1886 (offset -2 lines).
Hunk #9 FAILED at 2482.
1 out of 9 hunks FAILED -- saving rejects to file Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adrienne W..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12649175
Comment 5 Dana Jansens 2012-05-07 15:24:48 PDT 
Created attachment 140604 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-05-07 15:59:32 PDT 
Comment on attachment 140604 [details]
Patch for landing

Clearing flags on attachment: 140604

Committed r116362: <http://trac.webkit.org/changeset/116362>
Comment 7 WebKit Review Bot 2012-05-07 15:59:37 PDT 
All reviewed patches have been landed.  Closing bug.