Bug 85379 - Possible GCC x86 build error
Summary: Possible GCC x86 build error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-02 09:03 PDT by Yong Li
Modified: 2012-05-02 12:46 PDT (History)
1 user (show)

See Also:


Attachments
the patch (1.31 KB, patch)
2012-05-02 09:06 PDT, Yong Li
no flags Details | Formatted Diff | Diff
the patch (1.37 KB, patch)
2012-05-02 11:40 PDT, Yong Li
no flags Details | Formatted Diff | Diff
second try (1.40 KB, patch)
2012-05-02 12:04 PDT, Yong Li
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-05-02 09:03:02 PDT
The linker cannot find getHostCallReturnValue. It could still build if the linker is configured to ignore unreferenced symbols. But it is still good to fix this.
Comment 1 Yong Li 2012-05-02 09:06:58 PDT
Created attachment 139827 [details]
the patch
Comment 2 Yong Li 2012-05-02 09:19:27 PDT
sorry. I thought I had seen ".text" was used in DFG JIT lock... This link error must be due to other cause.
Comment 3 Yong Li 2012-05-02 11:39:04 PDT
reopening.
Comment 4 Yong Li 2012-05-02 11:40:16 PDT
Created attachment 139849 [details]
the patch

Always explicitly define the symbols in .text section.
Comment 5 Yong Li 2012-05-02 12:04:30 PDT
Created attachment 139853 [details]
second try
Comment 6 Rob Buis 2012-05-02 12:10:59 PDT
Comment on attachment 139853 [details]
second try

LGTM.
Comment 7 WebKit Review Bot 2012-05-02 12:46:32 PDT
Comment on attachment 139853 [details]
second try

Clearing flags on attachment: 139853

Committed r115867: <http://trac.webkit.org/changeset/115867>
Comment 8 WebKit Review Bot 2012-05-02 12:46:52 PDT
All reviewed patches have been landed.  Closing bug.