WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
85374
http "referer" header not properly set when using HTML5 pushState
https://bugs.webkit.org/show_bug.cgi?id=85374
Summary
http "referer" header not properly set when using HTML5 pushState
Milovan Zogovic
Reported
2012-05-02 07:42:30 PDT
Given I am on "bar.html", and I run following javascript: history.pushState( {}, "page1", "foo.html"); history.back(); // going back to "bar.html" location.href = "fuffy.html"; The fuffy.html will be requested with "referer: foo.html" header, even though request is originating from "bar.html".
Attachments
Patch
(5.01 KB, patch)
2012-05-04 06:07 PDT
,
jochen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Milovan Zogovic
Comment 1
2012-05-02 07:43:43 PDT
If you use the browser's back button (instead history.back()), the outcome is the same.
Eric Seidel (no email)
Comment 2
2012-05-02 10:47:54 PDT
Nifty.
jochen
Comment 3
2012-05-02 14:45:27 PDT
looks like history.back() doesn't properly update FrameLoader::m_outgoingReferrer
jochen
Comment 4
2012-05-04 06:07:02 PDT
Created
attachment 140201
[details]
Patch
WebKit Review Bot
Comment 5
2012-05-04 09:42:20 PDT
Comment on
attachment 140201
[details]
Patch Clearing flags on attachment: 140201 Committed
r116113
: <
http://trac.webkit.org/changeset/116113
>
WebKit Review Bot
Comment 6
2012-05-04 09:42:25 PDT
All reviewed patches have been landed. Closing bug.
Milovan Zogovic
Comment 7
2012-05-05 00:16:20 PDT
I'm total newb and this was my first bug report.. so i have no clue what is going on here :) Is there any js snippet that I can inject to make this work for older webkit browsers? I use this feature in production and this bug makes it impossible. I'd need to manually pass referrer everywhere..
jochen
Comment 8
2012-05-05 04:45:07 PDT
I think history.replaceState(history.state, "", ""); after the popstate event triggered by history.back(); should set the correct referrer on older webkits, but I haven't tried it.
Milovan Zogovic
Comment 9
2012-05-07 02:06:14 PDT
I've tried it.. but unfortunately it doesn't work :( Any other ideas? (In reply to
comment #8
)
> I think history.replaceState(history.state, "", ""); after the popstate event triggered by history.back(); should set the correct referrer on older webkits, but I haven't tried it.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug