[Qt] QQuickWebView does not allow for input from virtual keyboard

[Simon Hausmann]

[Qt] QQuickWebView does not allow for input from virtual keyboard

[Simon Hausmann]

As Michael analyzed correctly, the issue is that QQuickWebView never sets the ItemAcceptsInputMethod flag correctly, which leads the input method to believe that the item doesn't accept input method events at all.

[Simon Hausmann]

Created attachment 139761 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 139761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139761&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1618
> +void QQuickWebView::runJavaScriptInMainFrame(const QString &script, QObject *receiver, const char *method)

I saw that BB10 Cascades added a similar method, could you verify that we are using more or less the same API for this?

[Simon Hausmann]

Created attachment 139763 [details]
Patch

Rebased

[Simon Hausmann]

Comment on attachment 139761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139761&action=review

>> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1618
>> +void QQuickWebView::runJavaScriptInMainFrame(const QString &script, QObject *receiver, const char *method)
> 
> I saw that BB10 Cascades added a similar method, could you verify that we are using more or less the same API for this?

Hmm, this isn't public API though, just private for testing. I think a more JavaScript style API for this would be much better, along the lines of:

webView.runJavaScript("script here", function(result) {
   ...
})

[Simon Hausmann]

Comment on attachment 139763 [details]
Patch

Oops, clear this. Kenneth r+'ed the earlier patch, will land rebase right away.

[Simon Hausmann]

Committed r115801: <http://trac.webkit.org/changeset/115801>

[Lauro Moura Maranhao Neto]

After r115831 WebKit on N9 still has some problems regarding vkb.

Here's the steps:

- Go to www.google.com
- Search something (vkb works fine)
- On the search result page, tap the input field.
- VKB does not shows, even after returning to the main page.

[Simon Hausmann]

*** Bug 82736 has been marked as a duplicate of this bug. ***