Bug 85345 – Safari update media controls expectations

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Silvia Pfeiffer]

Safari update media controls expectations

[Silvia Pfeiffer]

Created attachment 139741 [details]
Patch

[Silvia Pfeiffer]

Tests on WebKit/Safari show color changes in addition to the 1px line change.
Needs a Safari dev's review for image rebaselining.

[Alexey Proskuryakov]

Have we even started using test_expectations on Mac?

[Andy Estes]

Comment on attachment 139741 [details]
Patch

Shouldn't we just check in new pixel results for the three IMAGE tests? We already checked in new text results earlier today. In the case of media/audio-repaint.html, that test is flaky and is skipped, so I'm not sure what adding it to test_expectations.txt does in this case. Maybe you can clarify.

[Silvia Pfeiffer]

(In reply to comment #4)
> (From update of attachment 139741 [details])
> Shouldn't we just check in new pixel results for the three IMAGE tests? We already checked in new text results earlier today. In the case of media/audio-repaint.html, that test is flaky and is skipped, so I'm not sure what adding it to test_expectations.txt does in this case. Maybe you can clarify.


My 1px outline bug fix changed the audio controls rendering. However, the IMAGE tests show a much bigger difference than just the 1px outline - there are also color/gradient changes. I checked the tests from before and after my change and those color changes are not caused by my patch. Therefore I thought it would be best if a Safari developer checked what the intended IMAGE results should be and did the rebasing of the IMAGE tests.

If you think it is ok, do go ahead and just check in the new pixel results.

[Silvia Pfeiffer]

Assigning to Eric for review of the pixel layout tests for Safari.

[Andy Estes]

Comment on attachment 139741 [details]
Patch

New pixel results landed in <http://trac.webkit.org/changeset/116355>. No need to change test_expectations.txt.