Bug 85344 – webkit-patch upload fails due to "nested FORMs"

• Status: NEW
• Component: Tools / Tests

[Ryosuke Niwa]

Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 69, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 64, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py", line 36, in run
    self._tool.bugs.reassign_bug(bug.id())
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 791, in reassign_bug
    self.browser.select_form(name="changeform")
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 499, in select_form
    global_form = self._factory.global_form
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 544, in __getattr__
    self.forms()
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 557, in forms
    self._forms_factory.forms())
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_html.py", line 237, in forms
    _urlunparse=_rfc3986.urlunsplit,
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 844, in ParseResponseEx
    _urlunparse=_urlunparse,
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 981, in _ParseFileEx
    fp.feed(data)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 758, in feed
    _sgmllib_copy.SGMLParser.feed(self, data)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_sgmllib_copy.py", line 110, in feed
    self.goahead(0)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_sgmllib_copy.py", line 144, in goahead
    k = self.parse_starttag(i)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_sgmllib_copy.py", line 302, in parse_starttag
    self.finish_starttag(tag, attrs)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_sgmllib_copy.py", line 351, in finish_starttag
    self.handle_starttag(tag, method, attrs)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_sgmllib_copy.py", line 387, in handle_starttag
    method(attrs)
  File "/Users/rniwa/webkit2/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_form.py", line 408, in start_form
    raise ParseError("nested FORMs")
webkitpy.thirdparty.autoinstalled.mechanize._form.ParseError: nested FORMs

[Ryosuke Niwa]

Maybe his is a regression in mechanize?

[Pravin D]

Steps to repo:
1. invoke ./Tools/Scripts/webkit-patch upload
2. Continue till prompt for bugzilla password is displayed. After entering the password the page is fetched see below for the seq

Fetching: https://bugs.webkit.org/show_bug.cgi?id=86746&ctype=xml&excludefield=attachmentdata
Fetching: https://bugs.webkit.org/show_bug.cgi?id=86746&ctype=xml&excludefield=attachmentdata
bugs.webkit.org login: <email ID>
bugs.webkit.org password for <email ID>: 
Store password in system keyring? [y/N]: 
Logging in as <email ID>...
Assigning bug <ID> to <email ID>
Traceback (most recent call last):
   File "./Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "./Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
.... 
Callstack as above...

hope this helps

[Eric Seidel (no email)]

Odd.  You might try removing Scripts/webkitpy/third_party, updating and trying again?