RESOLVED FIXED Bug 85329
[V8] Add an Isolate parameter to setJSWrapperForXXX() 
https://bugs.webkit.org/show_bug.cgi?id=85329
Summary [V8] Add an Isolate parameter to setJSWrapperForXXX()
Kentaro Hara
Reported 2012-05-01 17:44:02 PDT
The objective is to pass Isolate around in V8 bindings. In this bug we add an Isolate parameter to setJSWrapperForXXX() and pass Isolate in CodeGeneratorV8.pm. I'll pass Isolate in custom bindings in a follow-up patch.
Attachments
Patch (19.48 KB, patch)
2012-05-01 17:48 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-01 17:48:35 PDT
Created attachment 139718 [details] Patch
Adam Barth
Comment 2 2012-05-01 22:34:56 PDT
Comment on attachment 139718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139718&action=review > Source/WebCore/bindings/v8/V8DOMWrapper.h:158 > - void V8DOMWrapper::setJSWrapperForDOMObject(PassRefPtr<T> object, v8::Persistent<v8::Object> wrapper) > + void V8DOMWrapper::setJSWrapperForDOMObject(PassRefPtr<T> object, v8::Persistent<v8::Object> wrapper, v8::Isolate* isolate) If I were writing these patches, I probably would have made v8::Isolate the first argument to mirror ExecState in JSC, but that probably doesn't play nicely with having the isolate be optional.
Kentaro Hara
Comment 3 2012-05-01 22:36:38 PDT
(In reply to comment #2) > If I were writing these patches, I probably would have made v8::Isolate the first argument to mirror ExecState in JSC, but that probably doesn't play nicely with having the isolate be optional. Yeah, we put the Isolate in the last argument to make it optional.
WebKit Review Bot
Comment 4 2012-05-01 23:06:19 PDT
Comment on attachment 139718 [details] Patch Clearing flags on attachment: 139718 Committed r115797: <http://trac.webkit.org/changeset/115797>
WebKit Review Bot
Comment 5 2012-05-01 23:06:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.