The objective is to pass Isolate around in V8 bindings. In this bug we add an Isolate parameter to setJSWrapperForXXX() and pass Isolate in CodeGeneratorV8.pm. I'll pass Isolate in custom bindings in a follow-up patch.
Created attachment 139718 [details] Patch
Comment on attachment 139718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139718&action=review > Source/WebCore/bindings/v8/V8DOMWrapper.h:158 > - void V8DOMWrapper::setJSWrapperForDOMObject(PassRefPtr<T> object, v8::Persistent<v8::Object> wrapper) > + void V8DOMWrapper::setJSWrapperForDOMObject(PassRefPtr<T> object, v8::Persistent<v8::Object> wrapper, v8::Isolate* isolate) If I were writing these patches, I probably would have made v8::Isolate the first argument to mirror ExecState in JSC, but that probably doesn't play nicely with having the isolate be optional.
(In reply to comment #2) > If I were writing these patches, I probably would have made v8::Isolate the first argument to mirror ExecState in JSC, but that probably doesn't play nicely with having the isolate be optional. Yeah, we put the Isolate in the last argument to make it optional.
Comment on attachment 139718 [details] Patch Clearing flags on attachment: 139718 Committed r115797: <http://trac.webkit.org/changeset/115797>
All reviewed patches have been landed. Closing bug.