Bug 85309 - supportsExpandedScrollbars() should check for the method we actually call rather than a related method
Summary: supportsExpandedScrollbars() should check for the method we actually call rat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-01 14:15 PDT by Beth Dakin
Modified: 2012-05-02 12:47 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2012-05-01 14:18 PDT, Beth Dakin
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2012-05-01 14:15:43 PDT
In ScrollbarThemeMac, supportsExpandedScrollbars() checked if NSScrollerImp responds to isExpanded. The result of this function is used to determine whether or not is it safe to call setExpanded. We should just check for setExpanded instead.

<rdar://problem/11065691>
Comment 1 Beth Dakin 2012-05-01 14:18:11 PDT
Created attachment 139678 [details]
Patch
Comment 2 Beth Dakin 2012-05-02 06:42:32 PDT
Thanks Anders! http://trac.webkit.org/changeset/115823
Comment 3 Darin Adler 2012-05-02 11:19:58 PDT
This patch was wrong! The selector is setExpanded: with the colon, not setExpanded without a colon!
Comment 4 Anders Carlsson 2012-05-02 11:35:53 PDT
Oops!
Comment 5 Beth Dakin 2012-05-02 12:46:52 PDT
(In reply to comment #3)
> This patch was wrong! The selector is setExpanded: with the colon, not setExpanded without a colon!

Thanks for noticing that! Added the colon here: http://trac.webkit.org/changeset/115868