Bug 85290 - [Chromium] Fix WebPrerender::referrer() thunk.
: [Chromium] Fix WebPrerender::referrer() thunk.
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-05-01 09:22 PST by
Modified: 2012-05-01 11:22 PST (History)


Attachments
Patch (1.33 KB, patch)
2012-05-01 09:23 PST, Gavin Peters
no flags Review Patch | Details | Formatted Diff | Diff
Patch (1.35 KB, patch)
2012-05-01 09:39 PST, Gavin Peters
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-05-01 09:22:23 PST
[Chromium] Fix WebPrerender::referrer() thunk.
------- Comment #1 From 2012-05-01 09:23:51 PST -------
Created an attachment (id=139638) [details]
Patch
------- Comment #2 From 2012-05-01 09:25:14 PST -------
Amazingly, this code built fine in my clang, but it caused much trouble in gcc.

Abarth, WDYT?
------- Comment #3 From 2012-05-01 09:28:30 PST -------
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
------- Comment #4 From 2012-05-01 09:28:53 PST -------
Attachment 139638 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/Platform/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
------- Comment #5 From 2012-05-01 09:39:21 PST -------
Created an attachment (id=139641) [details]
Patch
------- Comment #6 From 2012-05-01 09:42:37 PST -------
webkit-patch is funny about changelogs and committed changes.  This second upload should have a good patch.
------- Comment #7 From 2012-05-01 10:59:34 PST -------
(note: this fix is in relation to bug 84880)
------- Comment #8 From 2012-05-01 11:02:23 PST -------
(From update of attachment 139641 [details])
doh.
------- Comment #9 From 2012-05-01 11:22:31 PST -------
(From update of attachment 139641 [details])
Clearing flags on attachment: 139641

Committed r115739: <http://trac.webkit.org/changeset/115739>
------- Comment #10 From 2012-05-01 11:22:38 PST -------
All reviewed patches have been landed.  Closing bug.