Bug 85284 - [BlackBerry] Add special attribute for alternate selection touch handling.
Summary: [BlackBerry] Add special attribute for alternate selection touch handling.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-01 08:07 PDT by Mike Fenton
Modified: 2012-05-03 08:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.23 KB, patch)
2012-05-01 08:10 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff
Rename Attribute patch. (3.47 KB, patch)
2012-05-03 08:00 PDT, Mike Fenton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-05-01 08:07:42 PDT
SSIA.
Comment 1 Mike Fenton 2012-05-01 08:10:43 PDT
Created attachment 139629 [details]
Patch
Comment 2 Antonio Gomes 2012-05-01 08:15:33 PDT
Comment on attachment 139629 [details]
Patch

bools :(
Comment 3 WebKit Review Bot 2012-05-01 08:32:09 PDT
Comment on attachment 139629 [details]
Patch

Clearing flags on attachment: 139629

Committed r115728: <http://trac.webkit.org/changeset/115728>
Comment 4 WebKit Review Bot 2012-05-01 08:32:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris H-C 2012-05-01 12:38:07 PDT
A little late now, but aren't vendor prefixes for HTML attributes supposed to be <vendor_name>_<attribute_name>, and the attribute-name should be camel-case, not hyphenated?

It looks like a CSS property, not an HTML attribute.
Comment 6 Antonio Gomes 2012-05-02 22:02:36 PDT
(In reply to comment #4)
> All reviewed patches have been landed.  Closing bug.

Agreed. We are fixing it.
Comment 7 Mike Fenton 2012-05-03 08:00:12 PDT
Created attachment 140013 [details]
Rename Attribute patch.
Comment 8 Rob Buis 2012-05-03 08:03:29 PDT
Comment on attachment 140013 [details]
Rename Attribute patch.

Looks good.
Comment 9 WebKit Review Bot 2012-05-03 08:39:52 PDT
Comment on attachment 140013 [details]
Rename Attribute patch.

Clearing flags on attachment: 140013

Committed r115974: <http://trac.webkit.org/changeset/115974>
Comment 10 WebKit Review Bot 2012-05-03 08:39:57 PDT
All reviewed patches have been landed.  Closing bug.