When a reftest mismatch occurs in testing, results.html entry holds a link to the diffs.png that contains a text line 'diff (undefined%)'. It seems reftest mismatch failures are not given a diff percent attribute in JSON data as expected by the results.html file.
Created attachment 139627 [details] Patch
Adding authors and reviewers of the last few changes to this file to get this reviewed. Thanks in advance!
Comment on attachment 139627 [details] Patch Attachment 139627 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12588578 New failing tests: fast/harness/results.html
Created attachment 139630 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 139633 [details] Patch Sigh, forgot the percent sign.
Comment on attachment 139633 [details] Patch This seems like the wrong layer to fix this in. We should fix ImageDiff to include the diff percentage for reftests as well.
Created attachment 139752 [details] Patch
Comment on attachment 139752 [details] Patch Looks great. Thanks!
Comment on attachment 139752 [details] Patch Clearing flags on attachment: 139752 Committed r115853: <http://trac.webkit.org/changeset/115853>
All reviewed patches have been landed. Closing bug.
Comment on attachment 139752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139752&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:71 > + diff_result = port.diff_image(driver_output.image, expected_driver_output.image, tolerance=0) Minor quibble: I would've probably used a destructuring assignment here, like "diff_result, diff_percent = port.diff_image(...)"