RenderThemeGtk::initMediaColors() sets m_panelColor, m_sliderColor and m_sliderColor to transparent black... I suspect this might be the effect of the recent update of gtk+ from 3.0 to 3.4 in our JHBuild moduleset.
Yep, reverting r114297 fixes the issue here.
Carlos would you mind having a look at this issue? It's quite annoying. If a WebKit patch is needed it should also be cherry-picked in the stable branch if possible because this visual regression is quite annoying.
I can't reproduce it with gtk+ from current git master
(In reply to comment #3) > I can't reproduce it with gtk+ from current git master So, what should we do then? Update our jhbuild's GTK+ version or find/backport the GTK+ commit that fixed the issue? I'm open to both options...
I'm fine with upgrading gtk+ in our jhbuild, unless it'd make it impossible to build our jhbuild stuff in fairly recent distributions, which I doubt will be the case.
(In reply to comment #5) > I'm fine with upgrading gtk+ in our jhbuild, unless it'd make it impossible to build our jhbuild stuff in fairly recent distributions, which I doubt will be the case. The fix for this issue should probably be in WebKit as we need to work properly with all GTK+ versions that we support during configuration.
We haven't really tried supporting all buggy versions of GTK+ or whatever else, specially bugs that come and go in a 1 release? =)
(In reply to comment #7) > We haven't really tried supporting all buggy versions of GTK+ or whatever else, specially bugs that come and go in a 1 release? =) Apologies! I misread this thread and understood falsely that the problem existed from 3.0 to 3.4.
I locally tried updating up to gtk+ 3.5.6 and still not seeing my media controls panel and timeline bar. Carlos, are you sure this all works fine for you in gtk+ master?
Yes, I can see the media controls with both MiniBrowser and GtkLauncher.
(In reply to comment #10) > Yes, I can see the media controls with both MiniBrowser and GtkLauncher. Can you attach a screenshot please? Just to make sure we're on the same page.
Created attachment 154957 [details] Patch
Comment on attachment 154957 [details] Patch Clearing flags on attachment: 154957 Committed r123959: <http://trac.webkit.org/changeset/123959>
All reviewed patches have been landed. Closing bug.