Bug 85272 – Calendar Picker: Add capability to add platform-specific style sheet

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Calendar Picker: Add capability to add platform-specific style sheet

[Kent Tamura]

Created attachment 139604 [details]
Patch

[Kentaro Hara]

Comment on attachment 139604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139604&action=review

> Source/WebCore/Resources/calendarPicker.css:-99
> -/* FIXME: We'd like to use the standard button appearance for non-Mac. */

Just a confirmation: Is it OK to remove the following css? I mean, aren't other platforms using .year-month-button in calendarPicker.css?

> Source/WebCore/Resources/calendarPickerMac.css:31
> +.year-month-button {

Just a confirmation: calendarPickerMac.css does not have .year-month-button:hover, which had existed in calendarPicker.css. Is it intentional?

[Kent Tamura]

Comment on attachment 139604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139604&action=review

>> Source/WebCore/Resources/calendarPicker.css:-99
>> -/* FIXME: We'd like to use the standard button appearance for non-Mac. */
> 
> Just a confirmation: Is it OK to remove the following css? I mean, aren't other platforms using .year-month-button in calendarPicker.css?

The year-month-button class is added to <input type=button>. Non-Mac platforms use the standard appearance of <input type=button>.

>> Source/WebCore/Resources/calendarPickerMac.css:31
>> +.year-month-button {
> 
> Just a confirmation: calendarPickerMac.css does not have .year-month-button:hover, which had existed in calendarPicker.css. Is it intentional?

Yes, it's intentional.
In general, OS X needs no :hover style for buttons and Windows needs it.  Before this patch, we applied year-month-button style to buttons in all platforms, and it was aligned to Windows-style. The :hover rule is not needed for this file because this files is for OS X.

[Kentaro Hara]

Comment on attachment 139604 [details]
Patch

Makes sense. r+ for the C++ part and rs for the css part.

[Kent Tamura]

Comment on attachment 139604 [details]
Patch

thanks!

[WebKit Review Bot]

Comment on attachment 139604 [details]
Patch

Clearing flags on attachment: 139604

Committed r115764: <http://trac.webkit.org/changeset/115764>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.