Bug 85272 - Calendar Picker: Add capability to add platform-specific style sheet
Summary: Calendar Picker: Add capability to add platform-specific style sheet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 53961
  Show dependency treegraph
 
Reported: 2012-05-01 03:11 PDT by Kent Tamura
Modified: 2012-05-01 17:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (11.63 KB, patch)
2012-05-01 03:22 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-05-01 03:11:42 PDT
Calendar Picker: Add capability to add platform-specific style sheet
Comment 1 Kent Tamura 2012-05-01 03:22:55 PDT
Created attachment 139604 [details]
Patch
Comment 2 Kentaro Hara 2012-05-01 09:12:14 PDT
Comment on attachment 139604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139604&action=review

> Source/WebCore/Resources/calendarPicker.css:-99
> -/* FIXME: We'd like to use the standard button appearance for non-Mac. */

Just a confirmation: Is it OK to remove the following css? I mean, aren't other platforms using .year-month-button in calendarPicker.css?

> Source/WebCore/Resources/calendarPickerMac.css:31
> +.year-month-button {

Just a confirmation: calendarPickerMac.css does not have .year-month-button:hover, which had existed in calendarPicker.css. Is it intentional?
Comment 3 Kent Tamura 2012-05-01 16:38:58 PDT
Comment on attachment 139604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139604&action=review

>> Source/WebCore/Resources/calendarPicker.css:-99
>> -/* FIXME: We'd like to use the standard button appearance for non-Mac. */
> 
> Just a confirmation: Is it OK to remove the following css? I mean, aren't other platforms using .year-month-button in calendarPicker.css?

The year-month-button class is added to <input type=button>. Non-Mac platforms use the standard appearance of <input type=button>.

>> Source/WebCore/Resources/calendarPickerMac.css:31
>> +.year-month-button {
> 
> Just a confirmation: calendarPickerMac.css does not have .year-month-button:hover, which had existed in calendarPicker.css. Is it intentional?

Yes, it's intentional.
In general, OS X needs no :hover style for buttons and Windows needs it.  Before this patch, we applied year-month-button style to buttons in all platforms, and it was aligned to Windows-style. The :hover rule is not needed for this file because this files is for OS X.
Comment 4 Kentaro Hara 2012-05-01 16:40:37 PDT
Comment on attachment 139604 [details]
Patch

Makes sense. r+ for the C++ part and rs for the css part.
Comment 5 Kent Tamura 2012-05-01 16:45:30 PDT
Comment on attachment 139604 [details]
Patch

thanks!
Comment 6 WebKit Review Bot 2012-05-01 17:12:04 PDT
Comment on attachment 139604 [details]
Patch

Clearing flags on attachment: 139604

Committed r115764: <http://trac.webkit.org/changeset/115764>
Comment 7 WebKit Review Bot 2012-05-01 17:12:09 PDT
All reviewed patches have been landed.  Closing bug.