Calendar Picker: Add capability to add platform-specific style sheet
Created attachment 139604 [details] Patch
Comment on attachment 139604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139604&action=review > Source/WebCore/Resources/calendarPicker.css:-99 > -/* FIXME: We'd like to use the standard button appearance for non-Mac. */ Just a confirmation: Is it OK to remove the following css? I mean, aren't other platforms using .year-month-button in calendarPicker.css? > Source/WebCore/Resources/calendarPickerMac.css:31 > +.year-month-button { Just a confirmation: calendarPickerMac.css does not have .year-month-button:hover, which had existed in calendarPicker.css. Is it intentional?
Comment on attachment 139604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139604&action=review >> Source/WebCore/Resources/calendarPicker.css:-99 >> -/* FIXME: We'd like to use the standard button appearance for non-Mac. */ > > Just a confirmation: Is it OK to remove the following css? I mean, aren't other platforms using .year-month-button in calendarPicker.css? The year-month-button class is added to <input type=button>. Non-Mac platforms use the standard appearance of <input type=button>. >> Source/WebCore/Resources/calendarPickerMac.css:31 >> +.year-month-button { > > Just a confirmation: calendarPickerMac.css does not have .year-month-button:hover, which had existed in calendarPicker.css. Is it intentional? Yes, it's intentional. In general, OS X needs no :hover style for buttons and Windows needs it. Before this patch, we applied year-month-button style to buttons in all platforms, and it was aligned to Windows-style. The :hover rule is not needed for this file because this files is for OS X.
Comment on attachment 139604 [details] Patch Makes sense. r+ for the C++ part and rs for the css part.
Comment on attachment 139604 [details] Patch thanks!
Comment on attachment 139604 [details] Patch Clearing flags on attachment: 139604 Committed r115764: <http://trac.webkit.org/changeset/115764>
All reviewed patches have been landed. Closing bug.