Bug 85249 - Change RenderBoxModelObject::calculateBackgroundImageGeometry to use roundToInt
Summary: Change RenderBoxModelObject::calculateBackgroundImageGeometry to use roundToInt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-04-30 17:40 PDT by Emil A Eklund
Modified: 2012-04-30 20:24 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.24 KB, patch)
2012-04-30 18:06 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch (2.38 KB, patch)
2012-04-30 18:21 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-04-30 17:40:35 PDT 
In RenderBoxModelObject::calculateBackgroundImageGeometry we need to use a modulo operator to compute the phase for the repeating background image. As the position will be a FractionalLayoutUnit we need to round it.
Comment 1 Emil A Eklund 2012-04-30 18:06:26 PDT 
Created attachment 139558 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-30 18:16:19 PDT 
Comment on attachment 139558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139558&action=review

> Source/WebCore/ChangeLog:9
> +        Prepare RenderBoxModelObject for FractionalLayoutUnits by adding rounding
> +        logic to calculateBackgroundImageGeometry.

Why?  Why should it round?  (i'm not saying it shouldn't,it's jus tnot very well explained here. :)
Comment 3 Emil A Eklund 2012-04-30 18:21:47 PDT 
Created attachment 139563 [details]
Patch
Comment 4 Emil A Eklund 2012-04-30 18:22:22 PDT 
Expanded on why.
Comment 5 Eric Seidel (no email) 2012-04-30 18:26:58 PDT 
Comment on attachment 139563 [details]
Patch

OK.
Comment 6 Emil A Eklund 2012-04-30 18:27:29 PDT 
Thanks Eric!
Comment 7 WebKit Review Bot 2012-04-30 20:23:59 PDT 
Comment on attachment 139563 [details]
Patch

Clearing flags on attachment: 139563

Committed r115707: <http://trac.webkit.org/changeset/115707>
Comment 8 WebKit Review Bot 2012-04-30 20:24:03 PDT 
All reviewed patches have been landed.  Closing bug.