Bug 85246 - Bytecode dumps should contain data about the state of get_by_id caches
: Bytecode dumps should contain data about the state of get_by_id caches
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-30 16:40 PDT by Filip Pizlo
Modified: 2012-05-21 15:32 PDT (History)
2 users (show)

See Also:


Attachments
the patch (47.32 KB, patch)
2012-04-30 16:47 PDT, Filip Pizlo
barraclough: review+
gns: commit‑queue-
Details | Formatted Diff | Diff
patch for landing (47.43 KB, patch)
2012-05-21 15:14 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-04-30 16:40:03 PDT
Currently bytecode dumping has some code to print the state of StructureStubInfo's, but that code has rotted, and is does not provide very many details - for example it will not tell you the offsets that we are using, and it will not tell you the full chains (for prototype accesses) or lists (for polymorphic accesses) being used.

As well, the old dumping code prints structure stub information out-of-line, which makes it a bit harder to grok.

The old code (which is rotten) should be axed, and replaced by something more informative.

Finally, it should be possible for the DFG to dump bytecode during parsing, so that we can see exactly what the DFG sees when making its optimization decisions.
Comment 1 Filip Pizlo 2012-04-30 16:47:51 PDT
Created attachment 139545 [details]
the patch
Comment 2 Gustavo Noronha (kov) 2012-04-30 17:03:52 PDT
Comment on attachment 139545 [details]
the patch

Attachment 139545 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12597247
Comment 3 Build Bot 2012-04-30 17:28:24 PDT
Comment on attachment 139545 [details]
the patch

Attachment 139545 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12592402
Comment 4 Early Warning System Bot 2012-04-30 17:37:50 PDT
Comment on attachment 139545 [details]
the patch

Attachment 139545 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12593390
Comment 5 Early Warning System Bot 2012-04-30 17:38:42 PDT
Comment on attachment 139545 [details]
the patch

Attachment 139545 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12582472
Comment 6 Filip Pizlo 2012-04-30 17:48:05 PDT
Landed (with build fixes) in http://trac.webkit.org/changeset/115694
Comment 7 Filip Pizlo 2012-05-21 15:14:06 PDT
Created attachment 143111 [details]
patch for landing
Comment 8 Filip Pizlo 2012-05-21 15:32:21 PDT
Merged in http://trac.webkit.org/changeset/117823