RESOLVED FIXED 85246
Bytecode dumps should contain data about the state of get_by_id caches 
https://bugs.webkit.org/show_bug.cgi?id=85246
Summary Bytecode dumps should contain data about the state of get_by_id caches
Filip Pizlo
Reported 2012-04-30 16:40:03 PDT
Currently bytecode dumping has some code to print the state of StructureStubInfo's, but that code has rotted, and is does not provide very many details - for example it will not tell you the offsets that we are using, and it will not tell you the full chains (for prototype accesses) or lists (for polymorphic accesses) being used. As well, the old dumping code prints structure stub information out-of-line, which makes it a bit harder to grok. The old code (which is rotten) should be axed, and replaced by something more informative. Finally, it should be possible for the DFG to dump bytecode during parsing, so that we can see exactly what the DFG sees when making its optimization decisions.
Attachments
the patch (47.32 KB, patch)
2012-04-30 16:47 PDT, Filip Pizlo 		barraclough: review+
gustavo: commit-queue-
DetailsFormatted DiffDiff
patch for landing (47.43 KB, patch)
2012-05-21 15:14 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-04-30 16:47:51 PDT
Created attachment 139545 [details] the patch
Gustavo Noronha (kov)
Comment 2 2012-04-30 17:03:52 PDT
Comment on attachment 139545 [details] the patch Attachment 139545 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12597247
Build Bot
Comment 3 2012-04-30 17:28:24 PDT
Comment on attachment 139545 [details] the patch Attachment 139545 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12592402
Early Warning System Bot
Comment 4 2012-04-30 17:37:50 PDT
Comment on attachment 139545 [details] the patch Attachment 139545 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12593390
Early Warning System Bot
Comment 5 2012-04-30 17:38:42 PDT
Comment on attachment 139545 [details] the patch Attachment 139545 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12582472
Filip Pizlo
Comment 6 2012-04-30 17:48:05 PDT
Landed (with build fixes) in http://trac.webkit.org/changeset/115694
Filip Pizlo
Comment 7 2012-05-21 15:14:06 PDT
Created attachment 143111 [details] patch for landing
Filip Pizlo
Comment 8 2012-05-21 15:32:21 PDT
Merged in http://trac.webkit.org/changeset/117823
Note You need to log in before you can comment on or make changes to this bug.