RESOLVED FIXED85243
Show the test name in the dashboard if showChrome==false and we're showing multiple tests 
https://bugs.webkit.org/show_bug.cgi?id=85243
Summary Show the test name in the dashboard if showChrome==false and we're showing mu...
Ojan Vafai
Reported 2012-04-30 16:15:21 PDT
Show the test name in the dashboard if showChrome==false and we're showing multiple tests
Attachments
Patch (11.61 KB, patch)
2012-04-30 16:16 PDT, Ojan Vafai 		dpranke: review+
ojan: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-04-30 16:16:40 PDT
Created attachment 139542 [details] Patch
Ojan Vafai
Comment 2 2012-04-30 16:34:50 PDT
This is confusing in the dashboard embedded in garden-o-matic because it shows data for two tests when viewing the canvas/philip tests because it shows the one for the test and the one for the virtual test. I supposed another solution would be to change the pattern matching to only return one tests if the string being searched for is exactly the name of a test. It's not clear to me which will be preferable for dealing with failing virtual tests, so I'm trying this for now and we'll see if this works reasonably well.
Ojan Vafai
Comment 3 2012-05-03 15:28:35 PDT
Comment on attachment 139542 [details] Patch This won't merge properly due to switching the unittests to qunit. I'll land manually.
Ojan Vafai
Comment 4 2012-05-03 15:34:08 PDT
Committed r116026: <http://trac.webkit.org/changeset/116026>
Note You need to log in before you can comment on or make changes to this bug.