RESOLVED FIXED Bug 85239
Update LayoutUnit usage in InlineFlowBox and RenderWidget 
https://bugs.webkit.org/show_bug.cgi?id=85239
Summary Update LayoutUnit usage in InlineFlowBox and RenderWidget
Levi Weintraub
Reported 2012-04-30 15:25:19 PDT
See changelog for description and justification.
Attachments
Patch (2.96 KB, patch)
2012-04-30 15:51 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.15 KB, patch)
2012-04-30 16:07 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-04-30 15:51:09 PDT
Created attachment 139534 [details] Patch
Eric Seidel (no email)
Comment 2 2012-04-30 15:54:18 PDT
Comment on attachment 139534 [details] Patch The widget stuff definitely makes sense. r=me to land that. The InlineFlowBox change feels like it could use a comment to explain why it's rounding. Are lines always pixel-aligned?
Levi Weintraub
Comment 3 2012-04-30 15:57:08 PDT
(In reply to comment #2) > (From update of attachment 139534 [details]) > The widget stuff definitely makes sense. r=me to land that. The InlineFlowBox change feels like it could use a comment to explain why it's rounding. Are lines always pixel-aligned? Root boxes are. You'll notice that top, maxAscent, and FontMetrics::ascent are all integers. I was surprised to discover this as well. I'll add a comment.
Levi Weintraub
Comment 4 2012-04-30 16:07:31 PDT
Created attachment 139540 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-04-30 16:41:21 PDT
Comment on attachment 139540 [details] Patch for landing Clearing flags on attachment: 139540 Committed r115689: <http://trac.webkit.org/changeset/115689>
WebKit Review Bot
Comment 6 2012-04-30 16:41:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.