Bug 85239 - Update LayoutUnit usage in InlineFlowBox and RenderWidget
Summary: Update LayoutUnit usage in InlineFlowBox and RenderWidget
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-04-30 15:25 PDT by Levi Weintraub
Modified: 2012-04-30 16:41 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2012-04-30 15:51 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Patch for landing (3.15 KB, patch)
2012-04-30 16:07 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-04-30 15:25:19 PDT 
See changelog for description and justification.
Comment 1 Levi Weintraub 2012-04-30 15:51:09 PDT 
Created attachment 139534 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-30 15:54:18 PDT 
Comment on attachment 139534 [details]
Patch

The widget stuff definitely makes sense.  r=me to land that.  The InlineFlowBox change feels like it could use a comment to explain why it's rounding.    Are lines always pixel-aligned?
Comment 3 Levi Weintraub 2012-04-30 15:57:08 PDT 
(In reply to comment #2)
> (From update of attachment 139534 [details])
> The widget stuff definitely makes sense.  r=me to land that.  The InlineFlowBox change feels like it could use a comment to explain why it's rounding.    Are lines always pixel-aligned?

Root boxes are. You'll notice that top, maxAscent, and FontMetrics::ascent are all integers. I was surprised to discover this as well. I'll add a comment.
Comment 4 Levi Weintraub 2012-04-30 16:07:31 PDT 
Created attachment 139540 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-04-30 16:41:21 PDT 
Comment on attachment 139540 [details]
Patch for landing

Clearing flags on attachment: 139540

Committed r115689: <http://trac.webkit.org/changeset/115689>
Comment 6 WebKit Review Bot 2012-04-30 16:41:30 PDT 
All reviewed patches have been landed.  Closing bug.