Bug 85236 - Oscillator must implement noteOn() and noteOff()
Summary: Oscillator must implement noteOn() and noteOff()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-30 14:47 PDT by Chris Rogers
Modified: 2012-05-04 18:27 PDT (History)
7 users (show)

See Also:

Attachments
Patch (772.79 KB, patch)
2012-04-30 15:06 PDT, Chris Rogers 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2012-04-30 14:47:19 PDT 
Oscillator must implement noteOn() and noteOff()
Comment 1 Chris Rogers 2012-04-30 15:06:30 PDT 
Created attachment 139527 [details]
Patch
Comment 2 Kenneth Russell 2012-05-04 17:05:11 PDT 
Comment on attachment 139527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139527&action=review

Looks good to me per your offline walkthrough of the code. r=me

> Source/WebCore/Modules/webaudio/Oscillator.cpp:211
> +        outputBus->zero();

This is redundant; just return.
Comment 3 Chris Rogers 2012-05-04 18:27:49 PDT 
Committed r116201: <http://trac.webkit.org/changeset/116201>