Add a histogram for rendertree size
Created attachment 139509 [details] Patch
Comment on attachment 139509 [details] Patch Attachment 139509 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12597184
Created attachment 139518 [details] Fix mac build
Comment on attachment 139518 [details] Fix mac build View in context: https://bugs.webkit.org/attachment.cgi?id=139518&action=review > Source/WebCore/page/Page.cpp:212 > +size_t Page::renderTreeSize() const A page may have many frames with distinct render trees. I'm not sure you mean to name it this way. > Source/WebCore/page/Page.cpp:217 > + size += frame->document()->renderArena()->totalRenderArenaSize(); is totalArenaSize accurate for your needs? Does it sum up all the object sizes? Does it include free space? Do you want it to?
Comment on attachment 139518 [details] Fix mac build View in context: https://bugs.webkit.org/attachment.cgi?id=139518&action=review >> Source/WebCore/page/Page.cpp:212 >> +size_t Page::renderTreeSize() const > > A page may have many frames with distinct render trees. I'm not sure you mean to name it this way. Do you have a suggestion? Not sure what's wrong with this name. This is the sum of the render tree sizes of all the frames in the page. I was just reusing the name from the WebKit2 code. >> Source/WebCore/page/Page.cpp:217 >> + size += frame->document()->renderArena()->totalRenderArenaSize(); > > is totalArenaSize accurate for your needs? Does it sum up all the object sizes? Does it include free space? Do you want it to? I have a followup patch that also gathers the total allocated bytes (i.e. includes the free space). I think, for the purposes of histograms, we want both numbers.
Comment on attachment 139518 [details] Fix mac build OK.
Comment on attachment 139518 [details] Fix mac build Clearing flags on attachment: 139518 Committed r115924: <http://trac.webkit.org/changeset/115924>
All reviewed patches have been landed. Closing bug.