One-line change to prevent an infinite loop in RenderDeprecatedFlexibleBox when it tries to distribute less than a pixel amongst its children.
Created attachment 139492 [details] Patch
Comment on attachment 139492 [details] Patch OK.
Comment on attachment 139492 [details] Patch Attachment 139492 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12593326 New failing tests: fast/flexbox/flex-hang.html
Created attachment 139508 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 139517 [details] Patch
Turns out we need an abs() (soon to be absoluteValue!) for when the values are negative. The changelog is still accurate :)
Comment on attachment 139517 [details] Patch ok, makes sense. I'm not sure how hot (if at all) this code is. If it turns out to be hot we could write this is faster ways I'm sure.
Comment on attachment 139517 [details] Patch Thanks again!
Comment on attachment 139517 [details] Patch Clearing flags on attachment: 139517 Committed r115687: <http://trac.webkit.org/changeset/115687>
All reviewed patches have been landed. Closing bug.
Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue.