Bug 85208 - REGRESSION(r115594): Caused 10 plus tests crash on Win/Linux debug (Requested by zhenyao on #webkit).
Summary: REGRESSION(r115594): Caused 10 plus tests crash on Win/Linux debug (Requested...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 84908
  Show dependency treegraph
 
Reported: 2012-04-30 10:46 PDT by WebKit Review Bot
Modified: 2017-07-18 08:27 PDT (History)
1 user (show)

See Also:


Attachments
ROLLOUT of r115594 (3.10 KB, patch)
2012-04-30 10:47 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-04-30 10:46:24 PDT
http://trac.webkit.org/changeset/115594 broke the build:
Caused 10 plus tests crash on Win/Linux debug (Requested by zhenyao on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-04-30 10:47:01 PDT
Created attachment 139474 [details]
ROLLOUT of r115594

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Ojan Vafai 2012-04-30 10:51:09 PDT
Can you list which tests it caused to crash? Or point to the build where it failed? We expect this assert to get hit since it points out a known bug. So, the right thing is probably to just mark the tests as crashing in debug.
Comment 3 Kentaro Hara 2012-04-30 10:55:24 PDT
(In reply to comment #2)
> Can you list which tests it caused to crash? Or point to the build where it failed? We expect this assert to get hit since it points out a known bug. So, the right thing is probably to just mark the tests as crashing in debug.

Yes! We want to know it!

For the time being, I landed a patch to remove ASSERT() from the code to avoid the crashes.