[chromium] Add WebDocument::referrerPolicy() which wraps the same method on Document

[chromium] Check whether a frame with a document exists before querying its referrer policy

Created attachment 139456 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 139456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139456&action=review

> Source/WebKit/chromium/src/WebFrameImpl.cpp:601
> +    if (m_frame && m_frame->document())

This doesn't seem quite right.

WebFrameImpl methods normally assume that m_frame is non-null.  See all the other
methods that just use m_frame without null checking it.

We similarly have methods that assume m_frame->document() will be non-null, although
many functions do null test document().

I think the right solution is actually to move referrerPolicy() to WebDocument since
it is really a property of the Document instead of the Frame.

Created attachment 139863 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 139863 [details]
Patch

Clearing flags on attachment: 139863

Committed r115889: <http://trac.webkit.org/changeset/115889>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.