Bug 85173 – [EFL] Frame load callbacks output is missing for redirections

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

Several tests rely on EFL's DRT properly printing frame load callbacks output for redirections such as "didReceiveServerRedirectForProvisionalLoadForFrame" and "willPerformClientRedirectToURL":
 http/tests/loading/307-after-303-after-post.html = TEXT
 http/tests/loading/redirect-methods.html = TEXT

[Chris Dumez]

Created attachment 139429 [details]
Patch

[Chris Dumez]

Created attachment 139958 [details]
Patch

Rebase on master.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 139958 [details]
Patch

Makes sense.

[Chris Dumez]

*** Bug 84573 has been marked as a duplicate of this bug. ***

[Chris Dumez]

Created attachment 140174 [details]
Patch

Rebase on master.

[Gyuyoung Kim]

Comment on attachment 140174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140174&action=review

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:570
> +    const char* url = static_cast<const char*>(eventInfo);

Is it better to use const_cast<char*> instead of static_cast<const char*> ?

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 140174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140174&action=review

>> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:570
>> +    const char* url = static_cast<const char*>(eventInfo);
> 
> Is it better to use const_cast<char*> instead of static_cast<const char*> ?

I don't see much value in doing that -- by using a const char* here we also indicate the value is not supposed to be changed.

[Antonio Gomes]

Comment on attachment 140174 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 140174 [details]
Patch

Rejecting attachment 140174 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
k/ewk_private.h
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
Hunk #2 succeeded at 499 (offset 1 line).
Hunk #3 succeeded at 558 (offset 1 line).
Hunk #4 succeeded at 589 (offset 1 line).
patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12565151

[WebKit Review Bot]

Comment on attachment 140174 [details]
Patch

Rejecting attachment 140174 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
k/ewk_private.h
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
Hunk #2 succeeded at 499 (offset 1 line).
Hunk #3 succeeded at 558 (offset 1 line).
Hunk #4 succeeded at 589 (offset 1 line).
patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12565177

[Chris Dumez]

Created attachment 140248 [details]
Patch for landing

Rebasing the patch for landing since the commit queue seems to have trouble.

[WebKit Review Bot]

Comment on attachment 140248 [details]
Patch for landing

Clearing flags on attachment: 140248

Committed r116119: <http://trac.webkit.org/changeset/116119>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.