Bug 85172 - Remove custom bindings code in JSHTMLCollectionCustom.cpp for HTMLPropertiesCollection.
Summary: Remove custom bindings code in JSHTMLCollectionCustom.cpp for HTMLPropertiesC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arko Saha
URL:
Keywords:
Depends on: 85216
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-30 03:04 PDT by Arko Saha
Modified: 2012-04-30 11:23 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.27 KB, patch)
2012-04-30 03:14 PDT, Arko Saha
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arko Saha 2012-04-30 03:04:47 PDT
Remove custom bindings code in JSHTMLCollectionCustom.cpp for HTMLPropertiesCollection. We should use [JSGenerateToJSObject] in HTMLPropertiesCollection.idl, so that it can generate toJS() in JSHTMLPropertiesCollection.cpp automatically.
Comment 1 Arko Saha 2012-04-30 03:14:15 PDT
Created attachment 139428 [details]
Patch
Comment 2 Kentaro Hara 2012-04-30 06:06:23 PDT
Comment on attachment 139428 [details]
Patch

toJS() is generated into the generated code, and toJS() still exists in JSHTMLCollectionCustom.cpp. Won't it cause toJS() redefinition?
Comment 3 Arko Saha 2012-04-30 06:17:22 PDT
(In reply to comment #2)
> (From update of attachment 139428 [details])
> toJS() is generated into the generated code, and toJS() still exists in JSHTMLCollectionCustom.cpp. Won't it cause toJS() redefinition?

We are adding [JSGenerateToJSObject] in HTMLPropertiesCollection.idl, so it will generate toJS() in JSHTMLPropertiesCollection.cpp not in JSHTMLCollection.cpp. So it will not complain for redefination. I have also compiled the code changes in my local system. Its working as expected.
Comment 4 Kentaro Hara 2012-04-30 07:09:52 PDT
Comment on attachment 139428 [details]
Patch

Thanks for the clarification.
Comment 5 Arko Saha 2012-04-30 07:15:12 PDT
Comment on attachment 139428 [details]
Patch

Thanks haraken for the review.
Comment 6 WebKit Review Bot 2012-04-30 08:13:53 PDT
Comment on attachment 139428 [details]
Patch

Clearing flags on attachment: 139428

Committed r115638: <http://trac.webkit.org/changeset/115638>
Comment 7 WebKit Review Bot 2012-04-30 08:14:01 PDT
All reviewed patches have been landed.  Closing bug.