Remove custom bindings code in JSHTMLCollectionCustom.cpp for HTMLPropertiesCollection. We should use [JSGenerateToJSObject] in HTMLPropertiesCollection.idl, so that it can generate toJS() in JSHTMLPropertiesCollection.cpp automatically.
Created attachment 139428 [details] Patch
Comment on attachment 139428 [details] Patch toJS() is generated into the generated code, and toJS() still exists in JSHTMLCollectionCustom.cpp. Won't it cause toJS() redefinition?
(In reply to comment #2) > (From update of attachment 139428 [details]) > toJS() is generated into the generated code, and toJS() still exists in JSHTMLCollectionCustom.cpp. Won't it cause toJS() redefinition? We are adding [JSGenerateToJSObject] in HTMLPropertiesCollection.idl, so it will generate toJS() in JSHTMLPropertiesCollection.cpp not in JSHTMLCollection.cpp. So it will not complain for redefination. I have also compiled the code changes in my local system. Its working as expected.
Comment on attachment 139428 [details] Patch Thanks for the clarification.
Comment on attachment 139428 [details] Patch Thanks haraken for the review.
Comment on attachment 139428 [details] Patch Clearing flags on attachment: 139428 Committed r115638: <http://trac.webkit.org/changeset/115638>
All reviewed patches have been landed. Closing bug.