The following test depends on overriding the "WebKitLoadSiteIconsKey" setting via LayoutTestController:
This functionality needs to be implemented in order to unskip this test case in EFL port.
Created attachment 139422 [details]
This patch seems to overlap with the one in bug 83007.
(In reply to comment #2)
> This patch seems to overlap with the one in bug 83007.
The patch at Bug 83007 does not support overriding "WebKitLoadSiteIconsKey" setting. If anything, the patches are complementary, not really overlapping. I don't see any issue with it, do you?
(In reply to comment #3)
> (In reply to comment #2)
> > This patch seems to overlap with the one in bug 83007.
> The patch at Bug 83007 does not support overriding "WebKitLoadSiteIconsKey" setting. If anything, the patches are complementary, not really overlapping. I don't see any issue with it, do you?
They both implement overridePreference and toBool() slightly differently; wouldn't it make sense to land this one after 83007?
Ok, adding dependency on Bug 83007.
Comment on attachment 139422 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=139422&action=review
> +static gboolean booleanFromValue(JSStringRef value)
Do not use unneeded glib type for efl port.
> + else
If there is no logic when keyString is not "WebKitLoadSiteIconKey", is it better to do nothing until we support other keyStrings ?
I don't see below code in webkit yet.
Created attachment 139749 [details]
Take feedback into consideration and make sure the patch is consistent with the one for Bug 83007.
Now, I don't think it matters which patch (Bug 83007 or this one) lands first.
Created attachment 139777 [details]
Make toBool() method inline and make sure the "WebKitLoadSiteIconsKey" setting is reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
Comment on attachment 139777 [details]
This patch looks fine now. Bug 83007 has landed, so you'll need to rebase.
Created attachment 139953 [details]
Rebase on master.
Comment on attachment 139953 [details]
Rejecting attachment 139953 [details] from commit-queue.
Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2
Last 500 characters of output:
patching file Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Andreas Kl..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/
Full output: http://queues.webkit.org/results/12531147
Created attachment 140218 [details]
Patch for landing
Comment on attachment 140218 [details]
Patch for landing
Clearing flags on attachment: 140218
Committed r116097: <http://trac.webkit.org/changeset/116097>
All reviewed patches have been landed. Closing bug.