Bug 8517 – change DerivedSources.make to use VPATH consistently

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Michael Emmel]

Make all pathes relative to $(WebCore) in DerivedSource.make

[Michael Emmel]

Created attachment 7872 [details]
patch to add WebCore variable

[Geoffrey Garen]

Comment on attachment 7872 [details]
patch to add WebCore variable

r=me

[Eric Seidel (no email)]

Comment on attachment 7872 [details]
patch to add WebCore variable

This should not be necessary.  the VPATH variable should take care of this...

[Darin Adler]

Comment on attachment 7872 [details]
patch to add WebCore variable

This is not a good idea. VPATH is supposed to handle this. Please don't land this change until we understand why that's not working.

[Michael Emmel]

(In reply to comment #4)
> (From update of attachment 7872 [details] [edit])
> This is not a good idea. VPATH is supposed to handle this. Please don't land
> this change until we understand why that's not working.
> 

It works its just at one point when I made the patch all paths were not relative
I don't think the makefile actually worked at that time it does now.
With that said all paths are not relative in the make file for example

ksvgcssvalues.h : $(WebCore)/ksvg2/scripts/cssmakevalues $(WebCore)/css/CSSValue

So its a mix of relative paths using the VPATH and some that don't.
I went the route of all absolute which I can understand not using but we should make it all relative or all absolute not a mix

[Michael Emmel]

Created attachment 7894 [details]
Patch to make more paths use VPATH


This patch makes the makefile more consitent in its use of VPATH.

Note VPATH works with the latest version in SVN the orginal patch was made agianst and older version of the file that had several problems.

[Maciej Stachowiak]

Comment on attachment 7894 [details]
Patch to make more paths use VPATH

r=me