RESOLVED FIXED 85169
[EFL] Default values for ewk_view video tracks settings should be documented 
https://bugs.webkit.org/show_bug.cgi?id=85169
Summary [EFL] Default values for ewk_view video tracks settings should be documented
Chris Dumez
Reported 2012-04-29 22:28:57 PDT
The default values for video tracks settings in ewk_view (captions, subtitles, text descriptions) are not documented. It should be mentioned in the documentation that those settings are disabled by default.
Attachments
Patch (2.04 KB, patch)
2012-04-29 22:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-04-29 22:33:21 PDT
Created attachment 139419 [details] Patch
Gyuyoung Kim
Comment 2 2012-04-29 23:23:16 PDT
Comment on attachment 139419 [details] Patch Looks fine.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-04-30 07:28:51 PDT
Comment on attachment 139419 [details] Patch Could you mention the defaults in the getters as well?
Chris Dumez
Comment 4 2012-04-30 08:38:48 PDT
(In reply to comment #3) > (From update of attachment 139419 [details]) > Could you mention the defaults in the getters as well? Do you mean the setters? Somehow, it feels weird to me to provide default values in the setters documentation. This is why my patch updates the documentation for the getters only.
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-04-30 11:04:47 PDT
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 139419 [details] [details]) > > Could you mention the defaults in the getters as well? > > Do you mean the setters? Somehow, it feels weird to me to provide default values in the setters documentation. This is why my patch updates the documentation for the getters only. Oops, I was confused by the function names the review page showed (it showed the setters, so I thought you had not documented the getters).
Gyuyoung Kim
Comment 6 2012-05-01 18:48:15 PDT
LGTM again.
WebKit Review Bot
Comment 7 2012-05-18 13:35:27 PDT
Comment on attachment 139419 [details] Patch Clearing flags on attachment: 139419 Committed r117617: <http://trac.webkit.org/changeset/117617>
WebKit Review Bot
Comment 8 2012-05-18 13:35:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.