Bug 85142 - Clarified JSGlobalData (JavaScript VM) lifetime
: Clarified JSGlobalData (JavaScript VM) lifetime
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-28 12:18 PST by
Modified: 2012-05-11 15:16 PST (History)


Attachments
Patch (33.61 KB, patch)
2012-04-28 13:15 PST, Geoffrey Garen
no flags Review Patch | Details | Formatted Diff | Diff
Patch (2.06 KB, patch)
2012-05-08 18:28 PST, Geoffrey Garen
ap: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-28 12:18:24 PST
Clarified JSGlobalData (JavaScript VM) lifetime
------- Comment #1 From 2012-04-28 13:15:37 PST -------
Created an attachment (id=139371) [details]
Patch
------- Comment #2 From 2012-04-28 13:26:20 PST -------
(From update of attachment 139371 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=139371&action=review

> Source/JavaScriptCore/ChangeLog:37
> +        notwithstaning, C++ does in fact know how to execute destructors in 

Speling error, notwithstaning.

> Source/JavaScriptCore/runtime/JSGlobalData.h:155
> +        Heap heap;

Could you add a comment here about the destruction order so nobody will accidentally move this?
------- Comment #3 From 2012-04-28 13:27:17 PST -------
(From update of attachment 139371 [details])
Attachment 139371 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12552666
------- Comment #4 From 2012-04-28 13:32:06 PST -------
(From update of attachment 139371 [details])
Attachment 139371 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12553679
------- Comment #5 From 2012-04-28 13:36:42 PST -------
(From update of attachment 139371 [details])
Attachment 139371 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12558684
------- Comment #6 From 2012-04-28 13:50:33 PST -------
Committed r115579: <http://trac.webkit.org/changeset/115579>
------- Comment #7 From 2012-04-30 11:11:50 PST -------
(From update of attachment 139371 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=139371&action=review

> Source/JavaScriptCore/ChangeLog:42
> +        (JSGlobalContextCreate): Removed compatibility shim for older 
> +        operating systems because it's no longer used.

This was not a shim for older operating systems, this was for applications linked against older versions of WebKit. I think that this removal is a mistake.
------- Comment #8 From 2012-05-08 18:21:06 PST -------
Reopening, because Alexey is right.
------- Comment #9 From 2012-05-08 18:28:24 PST -------
Created an attachment (id=140839) [details]
Patch
------- Comment #10 From 2012-05-08 21:42:10 PST -------
Geoff, please file a Radar for the follow-up fix.
------- Comment #11 From 2012-05-11 15:13:35 PST -------
<rdar://problem/11437914>
------- Comment #12 From 2012-05-11 15:16:05 PST -------
Committed r116809: <http://trac.webkit.org/changeset/116809>