Bug 85140 - [Qt] Enable CSS shaders in Qt (software mode)
Summary: [Qt] Enable CSS shaders in Qt (software mode)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-28 11:05 PDT by Noam Rosenthal
Modified: 2012-07-19 14:54 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.46 KB, patch)
2012-04-28 18:50 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (6.57 KB, patch)
2012-05-02 07:32 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (7.28 KB, patch)
2012-07-19 10:45 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-04-28 11:05:06 PDT
[Qt] Enable CSS shaders in Qt (software mode)
Comment 1 Noam Rosenthal 2012-04-28 18:50:59 PDT
Created attachment 139385 [details]
Patch
Comment 2 Noam Rosenthal 2012-05-02 07:32:51 PDT
Created attachment 139814 [details]
Patch
Comment 3 Simon Hausmann 2012-05-02 10:52:00 PDT
Comment on attachment 139814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139814&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:113
> +    if (!m_surface) {
> +        QGLWidget* widget = new QGLWidget;
> +        widget->setGeometry(0, 0, 0, 0);
> +        m_surface = widget->windowHandle();
> +        m_platformContext = widget->context()->contextHandle();
> +    }

That doesn't look like the right API to use with Qt 5 in WebCore. In fact this shouldn't even compile. I distinctly removed QtOpenGL and QtWidgets from the WebCore build a while ago. Maybe it somehow came back. QtOpenGL is linking against QtWidgets, which I don't want to re-introduce as dependency here.

The right API to use would be either low-level QPA or a QWindow with OpenGLSurface as surface type.
Comment 4 Noam Rosenthal 2012-05-02 10:53:26 PDT
> The right API to use would be either low-level QPA or a QWindow with OpenGLSurface as surface type.
Good point. I'll figure something out :)
Comment 5 Noam Rosenthal 2012-05-02 10:56:46 PDT
> That doesn't look like the right API to use with Qt 5 in WebCore. In fact this shouldn't even compile. I distinctly removed QtOpenGL and QtWidgets from the WebCore build a while ago. Maybe it somehow came back. QtOpenGL is linking against QtWidgets, which I don't want to re-introduce as dependency here.

btw this code is copied from PageClientQt, code that runs with Qt5+WebKit1...
Comment 6 Noam Rosenthal 2012-07-19 10:45:58 PDT
Created attachment 153303 [details]
Patch
Comment 7 WebKit Review Bot 2012-07-19 14:54:31 PDT
Comment on attachment 153303 [details]
Patch

Clearing flags on attachment: 153303

Committed r123150: <http://trac.webkit.org/changeset/123150>
Comment 8 WebKit Review Bot 2012-07-19 14:54:37 PDT
All reviewed patches have been landed.  Closing bug.