[Qt] Enable CSS shaders in Qt (software mode)
Created attachment 139385 [details] Patch
Created attachment 139814 [details] Patch
Comment on attachment 139814 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139814&action=review > Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:113 > + if (!m_surface) { > + QGLWidget* widget = new QGLWidget; > + widget->setGeometry(0, 0, 0, 0); > + m_surface = widget->windowHandle(); > + m_platformContext = widget->context()->contextHandle(); > + } That doesn't look like the right API to use with Qt 5 in WebCore. In fact this shouldn't even compile. I distinctly removed QtOpenGL and QtWidgets from the WebCore build a while ago. Maybe it somehow came back. QtOpenGL is linking against QtWidgets, which I don't want to re-introduce as dependency here. The right API to use would be either low-level QPA or a QWindow with OpenGLSurface as surface type.
> The right API to use would be either low-level QPA or a QWindow with OpenGLSurface as surface type. Good point. I'll figure something out :)
> That doesn't look like the right API to use with Qt 5 in WebCore. In fact this shouldn't even compile. I distinctly removed QtOpenGL and QtWidgets from the WebCore build a while ago. Maybe it somehow came back. QtOpenGL is linking against QtWidgets, which I don't want to re-introduce as dependency here. btw this code is copied from PageClientQt, code that runs with Qt5+WebKit1...
Created attachment 153303 [details] Patch
Comment on attachment 153303 [details] Patch Clearing flags on attachment: 153303 Committed r123150: <http://trac.webkit.org/changeset/123150>
All reviewed patches have been landed. Closing bug.