Bug 85137 - Web Inspector: InspectorFrontendHost.append has to be implemented for saving heap snapshots
Summary: Web Inspector: InspectorFrontendHost.append has to be implemented for saving ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-28 06:38 PDT by Ilya Tikhonovsky
Modified: 2012-04-28 12:11 PDT (History)
16 users (show)

See Also:


Attachments
Patch (8.44 KB, patch)
2012-04-28 06:50 PDT, Ilya Tikhonovsky
pfeldman: review+
Details | Formatted Diff | Diff
Patch (7.99 KB, patch)
2012-04-28 07:07 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-04-28 06:38:06 PDT
We can save a file with help of InspectorFrontendHost.save method,
but it is suitable only for relatively small portions of data and
can't process the 6Gb heap snapshot.
Comment 1 Ilya Tikhonovsky 2012-04-28 06:50:19 PDT
Created attachment 139360 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-28 06:53:50 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Ilya Tikhonovsky 2012-04-28 07:07:32 PDT
Created attachment 139361 [details]
Patch
Comment 4 Yury Semikhatsky 2012-04-28 09:56:13 PDT
Comment on attachment 139361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139361&action=review

> Source/WebCore/inspector/InspectorFrontendClient.h:64
> +    virtual void append(const WTF::String& url, const WTF::String& content) = 0;

We may want bool forceSaveAs argument here, otherwise the only way to change the file path would be to call save() for the URL and then append.
Comment 5 Ilya Tikhonovsky 2012-04-28 12:11:07 PDT
Comment on attachment 139361 [details]
Patch

Clearing flags on attachment: 139361

Committed r115577: <http://trac.webkit.org/changeset/115577>
Comment 6 Ilya Tikhonovsky 2012-04-28 12:11:17 PDT
All reviewed patches have been landed.  Closing bug.