- Merges Breakpoint and UIBreakpoint to have single instance - Extracts storage from the breakpoint manager - Makes breakpoint manager use source mapping from the script, not the presentation model - Removes breakpoints collection from the UISourceCode Unfortunately, there are too many inter-dependencies that require that these changes are done simultaneously.
Created attachment 139358 [details] Patch
Created attachment 139459 [details] Patch
Comment on attachment 139459 [details] Patch Attachment 139459 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12588297 New failing tests: inspector/debugger/script-formatter-breakpoints.html
Created attachment 139475 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 139632 [details] [Patch] Same with extensive test coverage
Comment on attachment 139632 [details] [Patch] Same with extensive test coverage Attachment 139632 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12582675 New failing tests: inspector/debugger/script-formatter-breakpoints.html
Created attachment 139636 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 139755 [details] [Patch] with formatter test fixed
Created attachment 139833 [details] Patch
Comment on attachment 139833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139833&action=review looks good. > Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:59 > + this._breakpointRemoved(event); Should be "if (this._items.contains(breakpoint)) return". > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:44 > + this._breakpoints = {}; Could you please remove this map?
Committed r115961: <http://trac.webkit.org/changeset/115961>