Bug 85131 – [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Sudarsana Nagineni (babu)]

Implement layoutTestController.setDomainRelaxationForbiddenForURLScheme in order to unskip the following test.
http/tests/security/setDomainRelaxationForbiddenForURLScheme.html

[Sudarsana Nagineni (babu)]

Created attachment 139348 [details]
Patch

Implement setDomainRelaxationForbiddenForURLScheme

[Martin Robinson]

Comment on attachment 139348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139348&action=review

Looks good, but there's one change I suggest...

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:916
> +    size_t bufferSize = JSStringGetMaximumUTF8CStringSize(scheme);
> +    GOwnPtr<gchar> schemeBuffer(static_cast<gchar*>(g_malloc(bufferSize)));
> +    JSStringGetUTF8CString(scheme, schemeBuffer.get(), bufferSize);
> +
> +    SchemeRegistry::setDomainRelaxationForbiddenForURLScheme(forbidden, String::fromUTF8(schemeBuffer.get()));

Most of the DumpRenderTreeSupportGtk method use char* instead of JSString. You should do the conversion in LayoutTestController.

[Sudarsana Nagineni (babu)]

(In reply to comment #2)
> Looks good, but there's one change I suggest...
> 
> > Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:916
> > +    size_t bufferSize = JSStringGetMaximumUTF8CStringSize(scheme);
> > +    GOwnPtr<gchar> schemeBuffer(static_cast<gchar*>(g_malloc(bufferSize)));
> > +    JSStringGetUTF8CString(scheme, schemeBuffer.get(), bufferSize);
> > +
> > +    SchemeRegistry::setDomainRelaxationForbiddenForURLScheme(forbidden, String::fromUTF8(schemeBuffer.get()));
> 
> Most of the DumpRenderTreeSupportGtk method use char* instead of JSString. You should do the conversion in LayoutTestController.

Thanks for the review Martin. I will make this change.

[Sudarsana Nagineni (babu)]

Created attachment 139399 [details]
Patch

Fixed review comment #2.

[WebKit Review Bot]

Comment on attachment 139399 [details]
Patch

Clearing flags on attachment: 139399

Committed r115597: <http://trac.webkit.org/changeset/115597>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.