Bug 85129 - Rename SVGPathParserFactory to SVGPathUtilities and remove the obsolete singleton
Summary: Rename SVGPathParserFactory to SVGPathUtilities and remove the obsolete singl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-28 01:40 PDT by Nikolas Zimmermann
Modified: 2012-04-28 02:44 PDT (History)
4 users (show)

See Also:


Attachments
Patch (61.59 KB, patch)
2012-04-28 02:19 PDT, Nikolas Zimmermann
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2012-04-28 01:40:44 PDT
Rename SVGPathParserFactory to SVGPathUtilities and remove the obsolete singleton
Comment 1 Nikolas Zimmermann 2012-04-28 02:19:17 PDT
Created attachment 139346 [details]
Patch
Comment 2 Antti Koivisto 2012-04-28 02:25:47 PDT
Comment on attachment 139346 [details]
Patch

Hope this is move rather than copy.
Comment 3 Nikolas Zimmermann 2012-04-28 02:28:53 PDT
Committed r115560: <http://trac.webkit.org/changeset/115560>
Comment 4 Csaba Osztrogonác 2012-04-28 02:33:21 PDT
Reopen, because it broke the Qt build:

../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromCircleElement(WebCore::SVGElement*, WebCore::Path&)':
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:45: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromEllipseElement(WebCore::SVGElement*, WebCore::Path&)':
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:60: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromLineElement(WebCore::SVGElement*, WebCore::Path&)':
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:69: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:70: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromPolygonElement(WebCore::SVGElement*, WebCore::Path&)':
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:88: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:92: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:94: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromPolylineElement(WebCore::SVGElement*, WebCore::Path&)':
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:106: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:110: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromRectElement(WebCore::SVGElement*, WebCore::Path&)':
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:139: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:139: error: incomplete type 'WebCore::Path' used in nested name specifier
../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:143: error: invalid use of incomplete type 'struct WebCore::Path'
../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path'


Could you fix it?
Comment 5 Early Warning System Bot 2012-04-28 02:34:42 PDT
Comment on attachment 139346 [details]
Patch

Attachment 139346 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12487028
Comment 6 Early Warning System Bot 2012-04-28 02:36:06 PDT
Comment on attachment 139346 [details]
Patch

Attachment 139346 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12556548
Comment 7 Nikolas Zimmermann 2012-04-28 02:44:28 PDT
Really sorry for not waiting for Qt EWS, I'll be sure to do that next time, landed Qt buildfix in r115561.