Rename SVGPathParserFactory to SVGPathUtilities and remove the obsolete singleton
Created attachment 139346 [details] Patch
Comment on attachment 139346 [details] Patch Hope this is move rather than copy.
Committed r115560: <http://trac.webkit.org/changeset/115560>
Reopen, because it broke the Qt build: ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromCircleElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:45: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromEllipseElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:60: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromLineElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:69: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:70: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromPolygonElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:88: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:92: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:94: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromPolylineElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:106: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:110: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp: In function 'void WebCore::updatePathFromRectElement(WebCore::SVGElement*, WebCore::Path&)': ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:139: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:139: error: incomplete type 'WebCore::Path' used in nested name specifier ../../../../Source/WebCore/rendering/svg/SVGPathData.cpp:143: error: invalid use of incomplete type 'struct WebCore::Path' ../../../../Source/WebCore/rendering/svg/SVGPathData.h:27: error: forward declaration of 'struct WebCore::Path' Could you fix it?
Comment on attachment 139346 [details] Patch Attachment 139346 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12487028
Comment on attachment 139346 [details] Patch Attachment 139346 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12556548
Really sorry for not waiting for Qt EWS, I'll be sure to do that next time, landed Qt buildfix in r115561.