Bug 85128 - Made WeakSet::allocate() static and removed its JSGlobalData argument
Summary: Made WeakSet::allocate() static and removed its JSGlobalData argument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-27 22:20 PDT by Geoffrey Garen
Modified: 2012-04-27 23:34 PDT (History)
1 user (show)

See Also:


Attachments
Patch (33.56 KB, patch)
2012-04-27 22:42 PDT, Geoffrey Garen
andersca: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-04-27 22:20:11 PDT
Made WeakSet::allocate() static and removed its JSGlobalData argument
Comment 1 Geoffrey Garen 2012-04-27 22:42:02 PDT
Created attachment 139339 [details]
Patch
Comment 2 Early Warning System Bot 2012-04-27 22:55:56 PDT
Comment on attachment 139339 [details]
Patch

Attachment 139339 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12552502
Comment 3 Geoffrey Garen 2012-04-27 22:56:53 PDT
Committed r115545: <http://trac.webkit.org/changeset/115545>
Comment 4 Csaba Osztrogonác 2012-04-27 23:33:26 PDT
Reopen, because it broke the Qt build. Why did you land it when the EWS said you will break the build?
Comment 5 Csaba Osztrogonác 2012-04-27 23:34:04 PDT
Oh fix was landed too - http://trac.webkit.org/changeset/115546