Bug 85115 – Remove SHADER_COMPILER constant

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

The SHADER_COMPILER constant was removed from the WebGL spec some time ago, but its removal wasn't verified by the conformance suite. It is being now, and needs to be removed from WebKit's implementation.

[Kenneth Russell]

Created attachment 139312 [details]
Patch

[Darin Adler]

Comment on attachment 139312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139312&action=review

> LayoutTests/fast/canvas/webgl/constants.html:449
> +NUM_COMPRESSED_TEXTURE_FORMATS : 0x86A2,
> +FIXED                          : 0x140C,
> +ACTIVE_UNIFORM_MAX_LENGTH      : 0x8B87,
> +ACTIVE_ATTRIBUTE_MAX_LENGTH    : 0x8B8A,
> +EXTENSIONS                     : 0x1F03,
> +INFO_LOG_LENGTH                : 0x8B84,
> +SHADER_SOURCE_LENGTH           : 0x8B88,
> +SHADER_COMPILER                : 0x8DFA,
> +SHADER_BINARY_FORMATS          : 0x8DF8,
> +NUM_SHADER_BINARY_FORMATS      : 0x8DF9,

Heh, it’s funny to have the actual values here for the removed constants.

[Kenneth Russell]

(In reply to comment #2)
> Heh, it’s funny to have the actual values here for the removed constants.

Yeah, maybe that was dumb of me...

[WebKit Review Bot]

Comment on attachment 139312 [details]
Patch

Clearing flags on attachment: 139312

Committed r115531: <http://trac.webkit.org/changeset/115531>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.