Bug 85113 – [CSS Shaders] Make CSS Shaders render to texture framebuffers

Bug 85113 - [CSS Shaders] Make CSS Shaders render to texture framebuffers


Summary:	[CSS Shaders] Make CSS Shaders render to texture framebuffers

Status:	RESOLVED FIXED

Product:	WebKit
Component:	Layout and Rendering
Version:	528+ (Nightly build)
Platform:	Unspecified Unspecified

Importance:	P2 Normal
Assigned To:	Alexandru Chiculita

URL:
Keywords:

Depends on:
Blocks:	85013
	Show dependency tree / graph

Reported:	2012-04-27 17:12 PST by Alexandru Chiculita
Modified:	2012-05-11 12:45 PST (History)

Attachments
Patch V1 (44.05 KB, patch) 2012-04-27 17:18 PST, Alexandru Chiculita	no flags	Review Patch \| Details \| Formatted Diff \| Diff
Archive of layout-test-results from ec2-cr-linux-01 (5.76 MB, application/zip) 2012-04-28 04:27 PST, WebKit Review Bot	no flags	Details
Patch for landing (74.96 KB, patch) 2012-05-11 12:02 PST, Alexandru Chiculita	no flags	Review Patch \| Details \| Formatted Diff \| Diff
Hide Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Alexandru Chiculita 2012-04-27 17:12:52 PST

Make CSS Shaders render to a texture instead of the main framebuffer. We want to use that when integrating into the platform accelerated pipeline.

------- Comment #1 From Alexandru Chiculita 2012-04-27 17:18:51 PST -------

Created an attachment (id=139309) [details]
Patch V1

------- Comment #2 From WebKit Review Bot 2012-04-28 04:27:50 PST -------

(From update of attachment 139309 [details])
Attachment 139309 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12552566

New failing tests:
css3/filters/custom/custom-filter-shader-cache.html
css3/filters/custom/effect-custom.html
css3/filters/custom/effect-custom-combined-missing.html

------- Comment #3 From WebKit Review Bot 2012-04-28 04:27:56 PST -------

Created an attachment (id=139355) [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

------- Comment #4 From Alexandru Chiculita 2012-04-28 09:22:06 PST -------

(In reply to comment #3)
> Created an attachment (id=139355) [details] [details]
> Archive of layout-test-results from ec2-cr-linux-01
> 
> The attached test failures were seen while running run-webkit-tests on the chromium-ews.
> Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

They just need rebaselines. I will updated them before committing / next patch.

------- Comment #5 From Dean Jackson 2012-04-30 10:44:08 PST -------

(From update of attachment 139309 [details])
This all looks good to me. Hopefully Stephen will review soon otherwise I'll do it.

------- Comment #6 From Alexandru Chiculita 2012-04-30 10:52:01 PST -------

(In reply to comment #5)
> (From update of attachment 139309 [details] [details])
> This all looks good to me. Hopefully Stephen will review soon otherwise I'll do it.

I just emailed Stephen and he is on vacation.

------- Comment #7 From Dean Jackson 2012-04-30 13:15:24 PST -------

(From update of attachment 139309 [details])
Since Stephen is out, I'll r+ here, assuming the chromium rebaseline works. Please speak up if you disagree.

------- Comment #8 From Alexandru Chiculita 2012-04-30 13:40:50 PST -------

(In reply to comment #7)
> (From update of attachment 139309 [details] [details])
> Since Stephen is out, I'll r+ here, assuming the chromium rebaseline works. Please speak up if you disagree.

Thanks. Will update and commit later today.

------- Comment #9 From Alexandru Chiculita 2012-05-11 12:02:42 PST -------

Created an attachment (id=141463) [details]
Patch for landing

------- Comment #10 From WebKit Review Bot 2012-05-11 12:45:00 PST -------

(From update of attachment 141463 [details])
Clearing flags on attachment: 141463

Committed r116795: <http://trac.webkit.org/changeset/116795>

------- Comment #11 From WebKit Review Bot 2012-05-11 12:45:37 PST -------

All reviewed patches have been landed.  Closing bug.