PerfTestRunner.computeStatistics incorrectly calculates min, max and median Requested by tomz on #webkit.
The data.sort() in this routine is doing an alphabetic sort. The dataset [1 3 7 10] shows the problem.
Created attachment 139308 [details] Patch
I'm not sure where tests for this should go but we most *certainly* need them for the statistics package. I'll be happy to write some.
Unfortunately we don't have any tests for this, and that's why we have this bug. Maybe we can add something in LayoutTests/fast/harness/ that pulls this file?
Now it makes sense that some of min/max/stdev looked bogus. But this problem should go away once we start importing all values. Still nice to fix it here thouh.
In that case, could you r+ this and I'll get the tests in ASAP? I'd rather not hold off while we're continuing to generate incorrect data. I tested the fix manually.
Comment on attachment 139308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139308&action=review > PerformanceTests/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). This line should appear before the description.
Committed r115598: <http://trac.webkit.org/changeset/115598>