Bug 85111 - PerfTestRunner.computeStatistics incorrectly calculates min, max and median
Summary: PerfTestRunner.computeStatistics incorrectly calculates min, max and median
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tom Zakrajsek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-27 16:42 PDT by WebKit Review Bot
Modified: 2012-04-30 08:53 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2012-04-27 16:49 PDT, Tom Zakrajsek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-04-27 16:42:58 PDT
PerfTestRunner.computeStatistics incorrectly calculates min, max and median
Requested by tomz on #webkit.
Comment 1 Tom Zakrajsek 2012-04-27 16:44:40 PDT
The data.sort() in this routine is doing an alphabetic sort.  The dataset [1 3 7 10] shows the problem.
Comment 2 Tom Zakrajsek 2012-04-27 16:49:34 PDT
Created attachment 139308 [details]
Patch
Comment 3 Tom Zakrajsek 2012-04-27 16:55:16 PDT
I'm not sure where tests for this should go but we most *certainly* need them for the statistics package.  I'll be happy to write some.
Comment 4 Ryosuke Niwa 2012-04-27 17:09:20 PDT
Unfortunately we don't have any tests for this, and that's why we have this bug. Maybe we can add something in LayoutTests/fast/harness/ that pulls this file?
Comment 5 Ryosuke Niwa 2012-04-27 17:11:51 PDT
Now it makes sense that some of min/max/stdev looked bogus. But this problem should go away once we start importing all values. Still nice to fix it here thouh.
Comment 6 Tom Zakrajsek 2012-04-27 23:30:42 PDT
In that case, could you r+ this and I'll get the tests in ASAP?  I'd rather not hold off while we're continuing to generate incorrect data.  I tested the fix manually.
Comment 7 Ryosuke Niwa 2012-04-28 02:26:42 PDT
Comment on attachment 139308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139308&action=review

> PerformanceTests/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).

This line should appear before the description.
Comment 8 Tom Zakrajsek 2012-04-29 11:21:29 PDT
Committed r115598: <http://trac.webkit.org/changeset/115598>