Bug 85096 - [Texmap] Leaves demo: wrong geometry when opacity animation kicks in
Summary: [Texmap] Leaves demo: wrong geometry when opacity animation kicks in
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-27 13:38 PDT by Noam Rosenthal
Modified: 2012-04-29 08:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.89 KB, patch)
2012-04-27 13:41 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (3.57 KB, patch)
2012-04-27 15:32 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-04-27 13:38:07 PDT
[Texmap] Leaves demo: wrong geometry when opacity animation kicks in
Comment 1 Noam Rosenthal 2012-04-27 13:41:57 PDT
Created attachment 139262 [details]
Patch
Comment 2 Jocelyn Turcotte 2012-04-27 14:04:46 PDT
Comment on attachment 139262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139262&action=review

> Source/WebCore/ChangeLog:11
> +        intermediate surfaces for preserves-3d. Also, we should multiply the compensation
> +        transform (options.transform) before we multiply the current item's transform, otherwise
> +        the transform-origin is incorrect.

The order of option.transform vs. m_transform.combined() didn't change in the code, only the order of options.offset changed, so maybe the changelog should be updated?

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:-153
> -            TransformationMatrix(options.transform)
> -            .multiply(m_transform.combined())
> -            .translate(options.offset.width(), options.offset.height());

The same order is present at the end of paintRecursive, should it be updated as well?
Comment 3 Noam Rosenthal 2012-04-27 15:32:11 PDT
Created attachment 139291 [details]
Patch
Comment 4 WebKit Review Bot 2012-04-29 08:19:30 PDT
Comment on attachment 139291 [details]
Patch

Clearing flags on attachment: 139291

Committed r115596: <http://trac.webkit.org/changeset/115596>
Comment 5 WebKit Review Bot 2012-04-29 08:19:35 PDT
All reviewed patches have been landed.  Closing bug.