Bug 85096 – [Texmap] Leaves demo: wrong geometry when opacity animation kicks in

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Noam Rosenthal]

[Texmap] Leaves demo: wrong geometry when opacity animation kicks in

[Noam Rosenthal]

Created attachment 139262 [details]
Patch

[Jocelyn Turcotte]

Comment on attachment 139262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139262&action=review

> Source/WebCore/ChangeLog:11
> +        intermediate surfaces for preserves-3d. Also, we should multiply the compensation
> +        transform (options.transform) before we multiply the current item's transform, otherwise
> +        the transform-origin is incorrect.

The order of option.transform vs. m_transform.combined() didn't change in the code, only the order of options.offset changed, so maybe the changelog should be updated?

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:-153
> -            TransformationMatrix(options.transform)
> -            .multiply(m_transform.combined())
> -            .translate(options.offset.width(), options.offset.height());

The same order is present at the end of paintRecursive, should it be updated as well?

[Noam Rosenthal]

Created attachment 139291 [details]
Patch

[WebKit Review Bot]

Comment on attachment 139291 [details]
Patch

Clearing flags on attachment: 139291

Committed r115596: <http://trac.webkit.org/changeset/115596>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.