RESOLVED FIXED 85093
[chromium] Allow WebMediaPlayerClientImpl to switch clients 
https://bugs.webkit.org/show_bug.cgi?id=85093
Summary [chromium] Allow WebMediaPlayerClientImpl to switch clients
Adrienne Walker
Reported 2012-04-27 13:19:15 PDT
[chromium] Allow WebMediaPlayerClientImpl to switch clients
Attachments
Patch (2.16 KB, patch)
2012-04-27 13:26 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Patch (9.11 KB, patch)
2012-04-27 15:20 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Clang fixes (9.10 KB, patch)
2012-05-04 18:23 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2012-04-27 13:26:50 PDT
Created attachment 139258 [details] Patch
Adrienne Walker
Comment 2 2012-04-27 13:27:31 PDT
Chromium bug: http://code.google.com/p/chromium/issues/detail?id=125113
James Robinson
Comment 3 2012-04-27 13:35:28 PDT
Comment on attachment 139258 [details] Patch Yup. Any thoughts on test? We can't really do a window->window transfer in a layout test, but we should be able to do that in a content or browser test, right?
Adrienne Walker
Comment 4 2012-04-27 13:38:22 PDT
(In reply to comment #3) > (From update of attachment 139258 [details]) > Yup. > > Any thoughts on test? We can't really do a window->window transfer in a layout test, but we should be able to do that in a content or browser test, right? Yeah, I was a little unsure about this too. I might be able to write a unit test to handle the underlying situation (switching clients); let me give that a go first before falling back on a content or browser test.
Adrienne Walker
Comment 5 2012-04-27 15:20:34 PDT
Created attachment 139288 [details] Patch
Adrienne Walker
Comment 6 2012-04-27 15:21:01 PDT
(In reply to comment #5) > Created an attachment (id=139288) [details] > Patch Now with unit tests.
James Robinson
Comment 7 2012-04-27 15:35:05 PDT
Comment on attachment 139288 [details] Patch Whee!
WebKit Review Bot
Comment 8 2012-04-27 19:55:07 PDT
Comment on attachment 139288 [details] Patch Clearing flags on attachment: 139288 Committed r115529: <http://trac.webkit.org/changeset/115529>
WebKit Review Bot
Comment 9 2012-04-27 19:55:12 PDT
All reviewed patches have been landed. Closing bug.
Adrienne Walker
Comment 10 2012-05-04 17:04:00 PDT
Rolled out in http://trac.webkit.org/changeset/115537.
Adrienne Walker
Comment 11 2012-05-04 18:23:11 PDT
Created attachment 140371 [details] Clang fixes
WebKit Review Bot
Comment 12 2012-05-06 15:06:08 PDT
Comment on attachment 140371 [details] Clang fixes Clearing flags on attachment: 140371 Committed r116242: <http://trac.webkit.org/changeset/116242>
WebKit Review Bot
Comment 13 2012-05-06 15:06:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.