Bug 85093 - [chromium] Allow WebMediaPlayerClientImpl to switch clients
Summary: [chromium] Allow WebMediaPlayerClientImpl to switch clients
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on: 85125
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-27 13:19 PDT by Adrienne Walker
Modified: 2012-05-06 15:06 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.16 KB, patch)
2012-04-27 13:26 PDT, Adrienne Walker
no flags Details | Formatted Diff | Diff
Patch (9.11 KB, patch)
2012-04-27 15:20 PDT, Adrienne Walker
no flags Details | Formatted Diff | Diff
Clang fixes (9.10 KB, patch)
2012-05-04 18:23 PDT, Adrienne Walker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2012-04-27 13:19:15 PDT
[chromium] Allow WebMediaPlayerClientImpl to switch clients
Comment 1 Adrienne Walker 2012-04-27 13:26:50 PDT
Created attachment 139258 [details]
Patch
Comment 2 Adrienne Walker 2012-04-27 13:27:31 PDT
Chromium bug: http://code.google.com/p/chromium/issues/detail?id=125113
Comment 3 James Robinson 2012-04-27 13:35:28 PDT
Comment on attachment 139258 [details]
Patch

Yup.

Any thoughts on test?  We can't really do a window->window transfer in a layout test, but we should be able to do that in a content or browser test, right?
Comment 4 Adrienne Walker 2012-04-27 13:38:22 PDT
(In reply to comment #3)
> (From update of attachment 139258 [details])
> Yup.
> 
> Any thoughts on test?  We can't really do a window->window transfer in a layout test, but we should be able to do that in a content or browser test, right?

Yeah, I was a little unsure about this too.  I might be able to write a unit test to handle the underlying situation (switching clients); let me give that a go first before falling back on a content or browser test.
Comment 5 Adrienne Walker 2012-04-27 15:20:34 PDT
Created attachment 139288 [details]
Patch
Comment 6 Adrienne Walker 2012-04-27 15:21:01 PDT
(In reply to comment #5)
> Created an attachment (id=139288) [details]
> Patch

Now with unit tests.
Comment 7 James Robinson 2012-04-27 15:35:05 PDT
Comment on attachment 139288 [details]
Patch

Whee!
Comment 8 WebKit Review Bot 2012-04-27 19:55:07 PDT
Comment on attachment 139288 [details]
Patch

Clearing flags on attachment: 139288

Committed r115529: <http://trac.webkit.org/changeset/115529>
Comment 9 WebKit Review Bot 2012-04-27 19:55:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Adrienne Walker 2012-05-04 17:04:00 PDT
Rolled out in http://trac.webkit.org/changeset/115537.
Comment 11 Adrienne Walker 2012-05-04 18:23:11 PDT
Created attachment 140371 [details]
Clang fixes
Comment 12 WebKit Review Bot 2012-05-06 15:06:08 PDT
Comment on attachment 140371 [details]
Clang fixes

Clearing flags on attachment: 140371

Committed r116242: <http://trac.webkit.org/changeset/116242>
Comment 13 WebKit Review Bot 2012-05-06 15:06:14 PDT
All reviewed patches have been landed.  Closing bug.