Bug 85088 – [Qt][WK2] Don't call syncRemoteContents from WebLayerTreeRenderer::paintToCurrentGLContext

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Yael]

It has recently moved to QQuickWebPage::updatePaintNode.

[Yael]

Created attachment 139245 [details]
Patch.

[Jocelyn Turcotte]

Comment on attachment 139245 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=139245&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:786
> +
> +    // Ensure that updatePaintNode is always called before painting.
> +    pageView->update();

This change should go in your fixed element patch and not here, since it is the one that is going to add code in updatePaintNode that must be called when the viewport move.

[Yael]

(In reply to comment #2)
> (From update of attachment 139245 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139245&action=review
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:786
> > +
> > +    // Ensure that updatePaintNode is always called before painting.
> > +    pageView->update();
> 
> This change should go in your fixed element patch and not here, since it is the one that is going to add code in updatePaintNode that must be called when the viewport move.

Existing fixed position tests are breaking without this change. I cannot remove syncRemoteContents without adding this.

[Noam Rosenthal]

Comment on attachment 139245 [details]
Patch.

LGTM, I agree with yael's comment.

[WebKit Review Bot]

Comment on attachment 139245 [details]
Patch.

Clearing flags on attachment: 139245

Committed r115515: <http://trac.webkit.org/changeset/115515>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.