Bug 85088 - [Qt][WK2] Don't call syncRemoteContents from WebLayerTreeRenderer::paintToCurrentGLContext
Summary: [Qt][WK2] Don't call syncRemoteContents from WebLayerTreeRenderer::paintToCur...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-27 11:50 PDT by Yael
Modified: 2012-04-27 16:48 PDT (History)
5 users (show)

See Also:


Attachments
Patch. (2.29 KB, patch)
2012-04-27 12:08 PDT, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2012-04-27 11:50:35 PDT
It has recently moved to QQuickWebPage::updatePaintNode.
Comment 1 Yael 2012-04-27 12:08:33 PDT
Created attachment 139245 [details]
Patch.
Comment 2 Jocelyn Turcotte 2012-04-27 12:28:07 PDT
Comment on attachment 139245 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=139245&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:786
> +
> +    // Ensure that updatePaintNode is always called before painting.
> +    pageView->update();

This change should go in your fixed element patch and not here, since it is the one that is going to add code in updatePaintNode that must be called when the viewport move.
Comment 3 Yael 2012-04-27 12:48:42 PDT
(In reply to comment #2)
> (From update of attachment 139245 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139245&action=review
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:786
> > +
> > +    // Ensure that updatePaintNode is always called before painting.
> > +    pageView->update();
> 
> This change should go in your fixed element patch and not here, since it is the one that is going to add code in updatePaintNode that must be called when the viewport move.

Existing fixed position tests are breaking without this change. I cannot remove syncRemoteContents without adding this.
Comment 4 Noam Rosenthal 2012-04-27 12:57:05 PDT
Comment on attachment 139245 [details]
Patch.

LGTM, I agree with yael's comment.
Comment 5 WebKit Review Bot 2012-04-27 16:48:15 PDT
Comment on attachment 139245 [details]
Patch.

Clearing flags on attachment: 139245

Committed r115515: <http://trac.webkit.org/changeset/115515>
Comment 6 WebKit Review Bot 2012-04-27 16:48:19 PDT
All reviewed patches have been landed.  Closing bug.