Bug 85087 - check-webkit-style sometimes does not allow creating scopes for RAII objects
Summary: check-webkit-style sometimes does not allow creating scopes for RAII objects
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-27 11:50 PDT by vollick
Modified: 2012-04-27 11:50 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vollick 2012-04-27 11:50:29 PDT 
check-webkit-style rejected at the following code:

    if (!visible) {
        {
            DebugScopedSetImplThread impl;
            m_layerTreeHost->didBecomeInvisibleOnImplThread(m_layerTreeHostImpl.get());
        }
        ... other code that must execute when !visible, but when impl is out of scope ...

The style check failed because the second curly brace wasn't on the previous line, but I think that it should be fine where it is.