Bug 85070 – optional SkRegion implementation of WebCore::Region

• Status: NEW
• Component: New Bugs

[Mike Reed]

optional SkRegion implementation of WebCore::Region

[Mike Reed]

Created attachment 139210 [details]
Patch

[Mike Reed]

Comment on attachment 139210 [details]
Patch

not intended for review yet, but to allow others to test/time this alternative.

[WebKit Review Bot]

Attachment 139210 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/Region.cpp:95:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/graphics/Region.cpp:41:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/Region.cpp:52:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/Region.cpp:56:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/Region.cpp:60:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/Region.cpp:64:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/Region.cpp:69:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/Region.cpp:73:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/Region.cpp:78:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/Region.cpp:82:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/Region.cpp:95:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/graphics/Region.h:43:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/graphics/Region.h:44:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 13 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Comment on attachment 139210 [details]
Patch

Attachment 139210 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12551231

[Early Warning System Bot]

Comment on attachment 139210 [details]
Patch

Attachment 139210 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12557235

[Early Warning System Bot]

Comment on attachment 139210 [details]
Patch

Attachment 139210 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12554233

[Build Bot]

Comment on attachment 139210 [details]
Patch

Attachment 139210 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12554234

[Build Bot]

Comment on attachment 139210 [details]
Patch

Attachment 139210 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12558223

[James Robinson]

Have you collected any perf data?

[Mike Reed]

on my linux build, I went from 22 fps (w/o patch) to 24 fps (w/ patch) using the test page in the chrome bug. Others should definitely try it locally as well.

http://code.google.com/p/chromium/issues/detail?id=124687

[Philippe Normand]

Comment on attachment 139210 [details]
Patch

Attachment 139210 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12557251

[Gyuyoung Kim]

Comment on attachment 139210 [details]
Patch

Attachment 139210 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12590486